Disable the button after it's pressed for the first time to prevent issue with multiple sends.
Also moved inputState.sendMultimediaMessage(selection, threadInfo); to an IIFE.
Details
Details
- Copy image to clipboard
- Paste image into TextInput to pull up ImagePasteModal
- Try hitting the send button in quick succession
- Make sure that the image only gets sent once
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- landmarch14 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/image-paste-modal.react.js | ||
|---|---|---|
| 37 | Alternatively, we could have a [imageSent, setImageSent] = React.useState(false); and then early exit from sendImage if imageSent is true | |
| native/chat/image-paste-modal.react.js | ||
|---|---|---|
| 44 ↗ | (On Diff #10361) | Does it make sense to wrap this in a try-catch and to call setSendButtonDisabled(false) if it throws? |
| native/chat/image-paste-modal.react.js | ||
|---|---|---|
| 44 ↗ | (On Diff #10361) | Maybe.. but we're currently calling navigation.goBackOnce(); at the start of this callback. We could await the call to sendMultimediaMessage, but that would keep the modal up a lot longer. My understanding is that if sendMultimediaMessage fails, it'll be like any other failed message and we'll have a "retry" button appear below it in the message list. We could do all of this in the modal, but I think we'd need to do a bit more than just wrapping in a try-catch and setSendButtonDisabled(false)? |
Comment Actions
(Going to land as-is, but happy to address feedback/introduce try-catch in a separate diff)
| native/chat/image-paste-modal.react.js | ||
|---|---|---|
| 44 ↗ | (On Diff #10361) | Ah yeah I missed navigation.goBackOnce(), this is more complicated than I thought. Let's just leave it as-is for now |