Page MenuHomePhabricator
Differential D3505

[web] [refactor] message preview styles solidified into one ternary statement
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 12:20 PM.
Tags
None
Referenced Files
F5085616: D3505.id10628.diff
Sat, Mar 29, 4:50 PM
F5082454: D3505.id10702.diff
Sat, Mar 29, 9:11 AM
Unknown Object (File)
Mon, Mar 17, 9:59 AM
Unknown Object (File)
Wed, Mar 12, 5:12 AM
Unknown Object (File)
Fri, Mar 7, 5:00 AM
Unknown Object (File)
Feb 16 2025, 5:20 AM
Unknown Object (File)
Feb 10 2025, 6:41 PM
Unknown Object (File)
Feb 8 2025, 10:29 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
• jacek
tomek
ashoat
Commits
rCOMMec5704f78a30: [web] [refactor] message preview styles solidified into one ternary statement
Summary

move styles into a single call

Test Plan

click and hover about chat thread list items. Functionality should be the same

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D3505
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 12:20 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 12:20 PM
Harbormaster completed remote builds in B7557: Diff 10628.Mar 23 2022, 12:25 PM
• benschac requested review of this revision.Mar 23 2022, 12:25 PM
• benschac added a parent revision: D3504: [web] [refactor] destructure props in message preview component.Mar 23 2022, 12:26 PM
• benschac added a child revision: D3506: [web] [refactor] simplify username logic in message preview.Mar 23 2022, 12:34 PM
• benschac updated this revision to Diff 10635.Mar 23 2022, 1:28 PM

remove array

Harbormaster completed remote builds in B7564: Diff 10635.Mar 23 2022, 1:33 PM
• benschac added reviewers: • jacek, tomek.Mar 23 2022, 1:54 PM
• benschac mentioned this in D3500: [web] [refactor] css color should be white.Mar 24 2022, 8:53 AM
• benschac updated this revision to Diff 10667.Mar 24 2022, 9:46 AM

rename classes from color to actions

Harbormaster completed remote builds in B7596: Diff 10667.Mar 24 2022, 9:51 AM
ashoat accepted this revision.Mar 24 2022, 6:04 PM
This revision is now accepted and ready to land.Mar 24 2022, 6:04 PM
tomek accepted this revision.Mar 25 2022, 3:06 AM
• benschac added a comment.Mar 25 2022, 6:54 AM

css['white'] project for this string before landing.

• benschac added a comment.Mar 25 2022, 10:01 AM
In D3505#95835, @benschac wrote:

css['white'] project for this string before landing.

searched the project and didn't see it anywhere.

• benschac updated this revision to Diff 10702.Mar 25 2022, 10:18 AM

rebase

This revision was landed with ongoing or failed builds.Mar 25 2022, 10:20 AM
Closed by commit rCOMMec5704f78a30: [web] [refactor] message preview styles solidified into one ternary statement (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMec5704f78a30: [web] [refactor] message preview styles solidified into one ternary statement.
• benschac added a comment.Mar 25 2022, 10:22 AM

I should have waited for the CI to finish. Sorry everyone.

Harbormaster completed remote builds in B7621: Diff 10702.Mar 25 2022, 10:23 AM

Revision Contents
Changeset List

PathSize
web/
chat/
8 lines
8 lines

Diff 10702

View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/chat/message-preview.react.js

Loading...