[docs][server] update dev environment docs to reflect changes to the url json files
ClosedPublic
Actions

Authored by varun on Mar 28 2022, 1:45 PM.

Details

Reviewers

atul
tomek
ashoat

Commits

rCOMMddbceea65a9d: [docs][server] update dev environment docs to reflect changes to the url json…

Summary

the server now expects two files called squadcal_url.json and commapp_url.json instead of just one app_url.json file. this diff updates the dev environment setup doc to reflect this change.

Test Plan

these are the instructions I followed to build the server locally.

Diff Detail

Repository

rCOMM Comm

Branch

varun/eng-893 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 28 2022, 1:45 PM

Herald added subscribers: • benschac, • karol, • adrian and 2 others. · View Herald TranscriptMar 28 2022, 1:45 PM

Harbormaster completed remote builds in B7650: Diff 10745.Mar 28 2022, 1:55 PM

varun requested review of this revision.Mar 28 2022, 1:55 PM

varun added a reviewer: tomek.Mar 28 2022, 3:11 PM

Since the dev environment doesn't need both of these, it would be great to simplify the setup and make it so these import calls don't fatal Node (by using dynamic await import calls wrapped in a try-catch). Then we wouldn't need to force the user to create two files. @varun, what do you think?

This revision is now accepted and ready to land.Mar 28 2022, 7:31 PM

add baseRoutePath to squadcal_url.json

Harbormaster completed remote builds in B7720: Diff 10822.Mar 30 2022, 8:22 AM

In D3528#96431, @ashoat wrote:

Since the dev environment doesn't need both of these, it would be great to simplify the setup and make it so these import calls don't fatal Node (by using dynamic await import calls wrapped in a try-catch). Then we wouldn't need to force the user to create two files. @varun, what do you think?

creating a linear task in the backlog to track this

Closed by commit rCOMMddbceea65a9d: [docs][server] update dev environment docs to reflect changes to the url json… (authored by varun). · Explain WhyMar 30 2022, 10:21 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMddbceea65a9d: [docs][server] update dev environment docs to reflect changes to the url json….