Page MenuHomePhabricator
Differential D3580

[server] Rename clientURLFromLocalURL to clientPathFromRouterPath
ClosedPublic
Actions

Authored by ashoat on Mar 30 2022, 11:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 12:12 AM
Unknown Object (File)
Sun, Nov 10, 12:12 AM
Unknown Object (File)
Sun, Nov 10, 12:06 AM
Unknown Object (File)
Tue, Nov 5, 1:24 AM
Unknown Object (File)
Tue, Oct 29, 5:31 AM
Unknown Object (File)
Tue, Oct 29, 5:31 AM
Unknown Object (File)
Oct 6 2024, 4:54 AM
Unknown Object (File)
Oct 6 2024, 4:50 AM
View All Files
Subscribers
• abosh
• adrian
atul
• benschac
• karol
tomek
varun

Details

Reviewers
varun
Commits
rCOMM180b14b8e8f2: [server] Rename clientURLFromLocalURL to clientPathFromRouterPath
Summary

We want to be clear that the input is a path relative to a specific Express router, and the outside is a path that the client can understand.

Response to @varun's feedback on D3554.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/client_url_variable_name
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
server/
src/
responders/
6 lines
6 lines
utils/
9 lines

Diff 10854

View Options

server/src/responders/landing-handler.js

Loading...
View Options

server/src/responders/website-responders.js

Loading...
View Options

server/src/utils/urls.js

Loading...