Page MenuHomePhabricator
Differential D3580

[server] Rename clientURLFromLocalURL to clientPathFromRouterPath
ClosedPublic
Actions

Authored by ashoat on Mar 30 2022, 11:08 PM.
Tags
None
Referenced Files
F2905364: D3580.id10854.diff
Sun, Oct 6, 4:54 AM
F2905356: D3580.id10913.diff
Sun, Oct 6, 4:50 AM
Unknown Object (File)
Fri, Oct 4, 6:07 PM
Unknown Object (File)
Tue, Sep 10, 11:43 PM
Unknown Object (File)
Tue, Sep 10, 11:43 PM
Unknown Object (File)
Tue, Sep 10, 11:43 PM
Unknown Object (File)
Tue, Sep 10, 11:41 PM
Unknown Object (File)
Aug 28 2024, 8:13 PM
View All 96 Files
Subscribers
• abosh
• adrian
atul
• benschac
• karol
tomek
varun

Details

Reviewers
varun
Commits
rCOMM180b14b8e8f2: [server] Rename clientURLFromLocalURL to clientPathFromRouterPath
Summary

We want to be clear that the input is a path relative to a specific Express router, and the outside is a path that the client can understand.

Response to @varun's feedback on D3554.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
server/
src/
responders/
6 lines
6 lines
utils/
9 lines

Diff 10913

View Options

server/src/responders/landing-handler.js

Loading...
View Options

server/src/responders/website-responders.js

Loading...
View Options

server/src/utils/urls.js

Loading...