Page MenuHomePhabricator

[web] [refactor] [ENG-716] destructure props in confirm-leave-thread-modal
ClosedPublic

Authored by benschac on Apr 4 2022, 12:59 PM.
Tags
None
Referenced Files
F3182117: D3613.id11080.diff
Fri, Nov 8, 7:31 AM
Unknown Object (File)
Sun, Nov 3, 3:20 PM
Unknown Object (File)
Sun, Nov 3, 3:20 PM
Unknown Object (File)
Sun, Nov 3, 3:20 PM
Unknown Object (File)
Sun, Nov 3, 3:20 PM
Unknown Object (File)
Sun, Nov 3, 3:18 PM
Unknown Object (File)
Oct 8 2024, 12:14 AM
Unknown Object (File)
Sep 23 2024, 11:32 PM

Details

Diff Detail

Repository
rCOMM Comm
Branch
leave-channel-thread
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul added inline comments.
web/modals/threads/confirm-leave-thread-modal.react.js
18

Personally find the second-level destructuring syntax to be weird, but that's how it is.

Would maybe prefer like

const {threadInfo, onClose, onConfirm} = props;
const {uiName} = threadInfo;

but it doesn't matter

This revision is now accepted and ready to land.Apr 5 2022, 12:21 PM
This revision was landed with ongoing or failed builds.Apr 5 2022, 1:29 PM
This revision was automatically updated to reflect the committed changes.