Page MenuHomePhabricator

[web] First pass at styling `ThreadSettingsModal`
ClosedPublic

Authored by atul on Apr 7 2022, 11:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 8, 1:29 AM
Unknown Object (File)
Fri, Oct 4, 7:38 PM
Unknown Object (File)
Oct 1 2024, 4:52 PM
Unknown Object (File)
Sep 17 2024, 6:57 PM
Unknown Object (File)
Sep 17 2024, 6:57 PM
Unknown Object (File)
Sep 17 2024, 6:57 PM
Unknown Object (File)
Sep 10 2024, 8:19 PM
Unknown Object (File)
Sep 10 2024, 8:19 PM

Details

Summary

Started with existing styles (which were borrowed from user-settings-modal.css and worked on styling ThreadSettingsModal so it looks decent.

Matched margin/padding/spacing of LoginForm as much as possible to maintain some consistency.

Before:

67b3.png (536×1 px, 49 KB)

After:

d547-1.png (914×708 px, 63 KB)

Test Plan

Opened ThreadSettingsModal, made some changes, ensured that the changes were made as expected. Did this a few times with thread name, description, color to make sure there weren't any issues.

Diff Detail

Repository
rCOMM Comm
Branch
land-april8 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Apr 7 2022, 11:25 AM
tomek added inline comments.
web/modals/threads/thread-settings-modal.css
53 ↗(On Diff #11193)

We set this for textarea in typography.css

This revision is now accepted and ready to land.Apr 8 2022, 3:01 AM
atul marked an inline comment as done.

address feedback

fix (checked diff history and saw that I cherry-picked an out of date commit)

This revision was landed with ongoing or failed builds.Apr 8 2022, 12:50 PM
This revision was automatically updated to reflect the committed changes.