[web] Rearrange `selectedThreadColorsObj` in `thread-utils`
ClosedPublic
Actions

Authored by atul on Apr 10 2022, 6:19 PM.

Details

Reviewers

tomek
• jacek
ashoat

Commits

rCOMMb51b1aa74d0e: [web] Rearrange `selectedThreadColorsObj` in `thread-utils`

Summary

Change the order of colors in thread-utils to match the order that we want in the ColorSelector component.

Test Plan

Looks as expected.

Diff Detail

Repository

rCOMM Comm

Branch

landapril11 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 10 2022, 6:19 PM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 10 2022, 6:19 PM

atul published this revision for review.Apr 10 2022, 6:21 PM

atul added inline comments.

lib/shared/thread-utils.js
93 ↗	(On Diff #11264)	Note that this color was removed and replaced by `#5C9F5F`, which was the green selected by Alicja and in the Figma designs. Every other color is just repositioned.

Harbormaster completed remote builds in B8047: Diff 11264.Apr 10 2022, 6:24 PM

ashoat accepted this revision.Apr 10 2022, 7:27 PM

This revision is now accepted and ready to land.Apr 10 2022, 7:27 PM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 11 2022, 10:24 AM

Closed by commit rCOMMb51b1aa74d0e: [web] Rearrange `selectedThreadColorsObj` in `thread-utils` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb51b1aa74d0e: [web] Rearrange `selectedThreadColorsObj` in `thread-utils`.

Harbormaster completed remote builds in B8082: Diff 11305.Apr 11 2022, 10:29 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

18 lines

Diff 11305

View Options

lib/shared/thread-utils.js

[web] Rearrange `selectedThreadColorsObj` in `thread-utils`ClosedPublicActions