Page MenuHomePhabricator
Differential D3705

[web] First pass at styling `ConfirmLeaveThreadModal`
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 2:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 8:59 AM
Unknown Object (File)
Thu, Nov 14, 8:59 AM
Unknown Object (File)
Thu, Nov 14, 8:59 AM
Unknown Object (File)
Sun, Nov 10, 12:37 AM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMM700f533b5091: [web] First pass at styling `ConfirmLeaveThreadModal`
Summary

Started with styles borrowed from thread-settings-modal.css and made some tweaks so it looks decent.

Before:

d3c4.png (330×706 px, 41 KB)

After:

a187.png (442×704 px, 44 KB)

Test Plan
  1. Created a "leavable" thread in my dev environment
  2. Clicked "Leave thread" in menu
  3. Ensured that the ConfirmLeaveThreadModal looked as expected
  4. Clicked the "Leave thread" button and confirmed that I had left the thread.

Diff Detail

Repository
rCOMM Comm
Branch
landapril13 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 11 2022, 2:48 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 2:48 PM
atul edited the summary of this revision. (Show Details)Apr 11 2022, 2:49 PM
Harbormaster completed remote builds in B8097: Diff 11324.Apr 11 2022, 2:52 PM
atul requested review of this revision.Apr 11 2022, 2:52 PM
tomek accepted this revision.Apr 13 2022, 4:18 AM
tomek added inline comments.
web/modals/threads/confirm-leave-thread-modal.css
6 ↗(On Diff #11324)

Do we need this?

10 ↗(On Diff #11324)

We should prefer using a variable from typography. We don't have 700 there, but I guess we should use --bold

This revision is now accepted and ready to land.Apr 13 2022, 4:18 AM
atul updated this revision to Diff 11422.Apr 13 2022, 8:35 AM
atul marked 2 inline comments as done.

rebase before addressing feedback

atul updated this revision to Diff 11423.Apr 13 2022, 8:36 AM

address feedback from @palys-swm

Harbormaster completed remote builds in B8160: Diff 11422.Apr 13 2022, 8:40 AM
Harbormaster completed remote builds in B8161: Diff 11423.Apr 13 2022, 8:43 AM
Closed by commit rCOMM700f533b5091: [web] First pass at styling `ConfirmLeaveThreadModal` (authored by atul). · Explain WhyApr 13 2022, 8:48 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM700f533b5091: [web] First pass at styling `ConfirmLeaveThreadModal`.

Revision Contents
Changeset List

Diff 11423

View Options

web/modals/threads/confirm-leave-thread-modal.css

Loading...
View Options

web/modals/threads/confirm-leave-thread-modal.react.js

Loading...