I'm Dockerizing the Node.js keyserver, which requires including files from various Yarn Workspaces. As a result I'm creating a .dockerignore in the root folder, and I figured it would make sure to merge all the .dockerignores into one. (Open to other approaches if people disagree.)
Details
Details
- Reviewers
tomek • jim varun • max - Commits
- rCOMM226ae03fff80: Create root .dockerignore file
Make sure I can build the Node.js keyserver from Docker. Also CI
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| .dockerignore | ||
|---|---|---|
| 10 ↗ | (On Diff #11349) | Need the .flowconfig files so native's postinstall hook doesn't crash when it calls yarn flow-mono create-symlinks native |
| 11–12 ↗ | (On Diff #11349) | Need these so native's postinstall hook doesn't crash when it calls yarn patch-package or npx pod-patch |
| 16 ↗ | (On Diff #11349) | Later on I'll need to add keyserver/facts and keyserver/secrets to this. We should not be copying in the files from my private dev environment into the Docker images we publish. For now I'm leaving them in to make testing easier |
| 20 ↗ | (On Diff #11349) | I copied this over from the old services/identity/.dockerignore, but this file doesn't appear to exist. @varun, are you planning on adding it later? |
| services/identity/.dockerignore | ||
| 4 ↗ | (On Diff #11349) | I deleted this line (rather, didn't move it over) because I'm pretty sure the .git folder only exists in the root of the repository. @varun, am I missing something? |
| services/tunnelbroker/.dockerignore | ||
| 1 ↗ | (On Diff #11349) | I deleted this line (rather, didn't move it over) following discussion in the Services Team chat on Comm |
| .dockerignore | ||
|---|---|---|
| 10 ↗ | (On Diff #11350) | Need the .flowconfig files so native's postinstall hook doesn't crash when it calls yarn flow-mono create-symlinks native |
| 11–12 ↗ | (On Diff #11350) | Need these so native's postinstall hook doesn't crash when it calls yarn patch-package or npx pod-patch |
| 13 ↗ | (On Diff #11350) | services need the protos here |
| 17 ↗ | (On Diff #11350) | Later on I'll need to add keyserver/facts and keyserver/secrets to this. We should not be copying in the files from my private dev environment into the Docker images we publish. For now I'm leaving them in to make testing easier |
| 21 ↗ | (On Diff #11350) | I copied this over from the old services/identity/.dockerignore, but this file doesn't appear to exist. @varun, are you planning on adding it later? |
| services/identity/.dockerignore | ||
| 4 ↗ | (On Diff #11350) | I deleted this line (rather, didn't move it over) because I'm pretty sure the .git folder only exists in the root of the repository. @varun, am I missing something? |
| services/tunnelbroker/.dockerignore | ||
| 1 ↗ | (On Diff #11350) | I deleted this line (rather, didn't move it over) following discussion in the Services Team chat on Comm |
Comment Actions
According to the docker-compose.yml, the context for Tunnelbroker, Backup, and Blob is ../, so a single .dockerignore file in the root folder makes sense. I'll make sure the Identity service has the same context.
| .dockerignore | ||
|---|---|---|
| 21 ↗ | (On Diff #11350) | Ah, no, this line can be removed |
| services/identity/.dockerignore | ||
| 4 ↗ | (On Diff #11350) | Safe to delete this. cargo init automatically initializes a git repo, but I deleted all the git files in this Rust project when I moved it into the Comm repo |
| .dockerignore | ||
|---|---|---|
| 21 ↗ | (On Diff #11350) | Cool, will remove |