follow up from https://phabricator.ashoat.com/D3539 comments that were not landed
Details
Diff Detail
- Repository
- rCOMM Comm
- Branch
- benjamin/eng-1024-follow-up-from-eng-766
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
How about @palys-swm's questions?
It looks ok as a workaround. Have you tested how it behaves if we zoom the page or resize it?
For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via css. What do you think?
I haven't, but I would assume not great since we're using relative units (rem) for font and (px) for padding they'll likely break. I'm not terribly worried because this is a short-term/temp fix and we don't have many users on the product / in more of a closed beta state.
For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via css. What do you think?
Yes, I agree that's a good option. I additionally tried @atul's option of just setting a <img src={svg" like so. I think that's the most straightforward path and easiest technique to try. I can give the CSS drawing option a try next if the img tag approach isn't optimal.