Page MenuHomePhabricator

[web] [fix] [ENG-1024] Additional Changes for ENG-766 that were missed before landing.
ClosedPublic

Authored by benschac on Apr 19 2022, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 6:35 PM
Unknown Object (File)
Wed, Oct 9, 6:43 PM
Unknown Object (File)
Wed, Oct 9, 6:43 PM
Unknown Object (File)
Wed, Oct 9, 6:43 PM
Unknown Object (File)
Wed, Oct 9, 5:59 PM
Unknown Object (File)
Sep 28 2024, 8:31 AM
Unknown Object (File)
Sep 25 2024, 7:13 PM
Unknown Object (File)
Sep 16 2024, 2:16 PM

Details

Summary

follow up from https://phabricator.ashoat.com/D3539 comments that were not landed

Test Plan

make sure all diff review has been addressed correctly.

Diff Detail

Repository
rCOMM Comm
Branch
benjamin/eng-1024-follow-up-from-eng-766
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

benschac planned changes to this revision.
ashoat requested changes to this revision.Apr 21 2022, 1:43 PM

Bad diff title

This revision now requires changes to proceed.Apr 21 2022, 1:43 PM
benschac retitled this revision from [web] [fix] [ENG-1024] follow up changes for ENG-766 to [web] [fix] [ENG-1024] Additional Changes for ENG-766 that were missed before landing..Apr 22 2022, 10:49 AM

How about @palys-swm's questions?

It looks ok as a workaround. Have you tested how it behaves if we zoom the page or resize it?

For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via css. What do you think?

This revision is now accepted and ready to land.Apr 24 2022, 4:35 PM

How about @palys-swm's questions?

It looks ok as a workaround. Have you tested how it behaves if we zoom the page or resize it?

I haven't, but I would assume not great since we're using relative units (rem) for font and (px) for padding they'll likely break. I'm not terribly worried because this is a short-term/temp fix and we don't have many users on the product / in more of a closed beta state.

For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via css. What do you think?

Yes, I agree that's a good option. I additionally tried @atul's option of just setting a <img src={svg" like so. I think that's the most straightforward path and easiest technique to try. I can give the CSS drawing option a try next if the img tag approach isn't optimal.