[services] Tunnelbroker - Test of `createdAt` field in the messageItem
ClosedPublic
Actions

Authored by • max on Apr 21 2022, 7:55 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMM0e6314a5b37f: [services] Tunnelbroker - Test of `createdAt` field in the messageItem

Summary

The new field createdAt was added at D3805. Adding the test for it to the messageItem fields testings.

Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository

rCOMM Comm

Branch

tunnelbroker-tests-createdat

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Apr 21 2022, 7:55 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 21 2022, 7:55 AM

I think this little test addition would be enough not to flood the tests for each field and spend too much on it.

• max mentioned this in D3805: [services] Tunnelbroker - Add `createdAt` timestamp to the `messageItem`.Apr 21 2022, 7:58 AM

Harbormaster completed remote builds in B8403: Diff 11727.Apr 21 2022, 8:00 AM

• max requested review of this revision.Apr 21 2022, 8:00 AM

• max retitled this revision from [services] Tunnelbroker - Append test of `createdAt` field in the messageItem to [services] Tunnelbroker - Test of `createdAt` field in the messageItem.Apr 21 2022, 8:02 AM

tomek requested changes to this revision.Apr 21 2022, 8:41 AM

tomek added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
56	Can we get a timestamp at the beginning of this test and compare it to `getCreatedAt` instead of having a hardcoded value?

This revision now requires changes to proceed.Apr 21 2022, 8:41 AM

Changed equal of the createdAt to the generated timestamp.

• max marked an inline comment as done.Apr 22 2022, 1:10 AM

• max added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
56	Can we get a timestamp at the beginning of this test and compare it to `getCreatedAt` instead of having a hardcoded value? That makes sense to me, thanks. Changed it.

Harbormaster completed remote builds in B8434: Diff 11773.Apr 22 2022, 1:15 AM

tomek accepted this revision.Apr 25 2022, 2:23 AM

tomek added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
24 ↗	(On Diff #11773)	This change shouldn't be a part of this diff. Why it was introduced?
56 ↗	(On Diff #11773)	We can also keep the second condition

This revision is now accepted and ready to land.Apr 25 2022, 2:23 AM

• max mentioned this in rCOMM269032a80cf0: [services] Tunnelbroker - Add `createdAt` timestamp to the `messageItem`.Apr 25 2022, 5:43 AM

Rebased on master, fixes on comments.

• max marked 2 inline comments as done.Apr 25 2022, 5:51 AM

• max added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
24 ↗	(On Diff #11773)	This change shouldn't be a part of this diff. Why it was introduced? Removed it. Thanks.
56 ↗	(On Diff #11773)	We can also keep the second condition Let's keep them both. Added them.