Introduce list of pending users to add below search bar in AddMembersModal.
The diff also excludes pending users from main list in Modal, so they don't appear twice.
Details
Details
Open "Members Modal", try to add users from list, pending users appears below search bar.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jacek/pending-users-to-add
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
This looks amazing! Adding @ashoat so he can take a look.
web/modals/threads/members/add-members-modal.react.js | ||
---|---|---|
117 | In some places we use Array.from(pendingUsersToAdd) and here we use spread operator. It doesn't matter that much, but it might be a nice idea to be consistent | |
130 | Have you considered using a callback here? |