Page MenuHomePhabricator

[native] [fix] [ENG-1078] fix hot reload loosing state
ClosedPublic

Authored by benschac on May 3 2022, 2:07 PM.
Tags
None
Referenced Files
F3402004: D3901.id12180.diff
Mon, Dec 2, 2:54 PM
F3401875: D3901.id12179.diff
Mon, Dec 2, 2:24 PM
F3401628: D3901.diff
Mon, Dec 2, 1:05 PM
Unknown Object (File)
Sun, Nov 10, 2:41 PM
Unknown Object (File)
Sat, Nov 9, 11:39 AM
Unknown Object (File)
Sat, Nov 9, 11:39 AM
Unknown Object (File)
Fri, Nov 8, 11:24 PM
Unknown Object (File)
Fri, Nov 8, 12:46 PM

Details

Summary

fix for https://linear.app/comm/issue/ENG-1078/chat-view-loses-state-during-fast-refresh. Additionally, the reason this works is because https://reactnative.dev/docs/fast-refresh#how-it-works which is why we remove the additional exports from InlineSidebar and moved them into a new file.

If you edit a module with exports that aren't React components, Fast Refresh will re-run both that module, and the other modules importing it. So if both Button.js and Modal.js import Theme.js, editing Theme.js will update both components.

Test Plan

follow steps in issue. 1. update inline-sidebar.react in native, have the chatview (conversation) open, hot-reload should not navigate you away from the screen that you were currently on.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable