[web] Fix `See more...` button alignment regression
ClosedPublic
Actions

Authored by • abosh on May 4 2022, 11:15 AM.

Details

Reviewers

atul
• benschac

Commits

rCOMM6497c6952071: [web] Fix `See more...` button alignment regression

Summary

Noticed a regression in the See more... sidebar button's alignment with the sidebars. Fixed this by adjusting the padding-left.

As an aside, because the ChatThreadList component is being actively worked on, I suspect the alignment may be messed up in the future if the arrow/sidebar get bigger or smaller. Therefore, we should probably pull in the padding from some central place so we don't introduce new regressions when modifying the styling of one part of the component.

Test Plan

Tested on Chrome/Safari and works as expected:
Before:

Screen Shot 2022-05-04 at 11.08.13 AM.png (384×810 px, 35 KB)

After:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.May 4 2022, 11:15 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMay 4 2022, 11:15 AM

• abosh edited the summary of this revision. (Show Details)May 4 2022, 11:16 AM

• abosh edited the test plan for this revision. (Show Details)

• abosh added 1 blocking reviewer(s): atul.

Harbormaster completed remote builds in B8785: Diff 12232.May 4 2022, 11:19 AM

• abosh requested review of this revision.May 4 2022, 11:19 AM

Adding @benschac since he was working on this recently and I suspect he introduced the regression (but not sure)

Went over this fix with @yayabosh and it made sense to me.

I hadn't noticed the issue since none of the threads in my dev environment had enough recent sidebars for the "See more..." button to appear. Tough one to catch

This revision is now accepted and ready to land.May 4 2022, 2:35 PM

Closed by commit rCOMM6497c6952071: [web] Fix `See more...` button alignment regression (authored by • abosh). · Explain WhyMay 4 2022, 4:53 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM6497c6952071: [web] Fix `See more...` button alignment regression.