[native][refactor] sort colors in theme
ClosedPublic
Actions

Authored by • benschac on May 5 2022, 9:38 AM.

Details

Reviewers

atul
tomek
• jacek
• abosh

Commits

rCOMM3f0af4aa3eb5: [native][refactor] sort colors in theme

Summary

sort colors in theme. I think long term we should think about using a theme lib that has a bit more flexibility than what we have now. Just for dx at the moment, sorting these values makes finding them a little easier.

Test Plan

in vscode run command + shift + p search for sort lines asc. result should be the same.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.May 5 2022, 9:38 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMay 5 2022, 9:38 AM

• benschac edited the test plan for this revision. (Show Details)May 5 2022, 9:40 AM

Harbormaster completed remote builds in B8824: Diff 12299.May 5 2022, 9:43 AM

• benschac requested review of this revision.May 5 2022, 9:43 AM

nice!

(didn't go line-by-line, but trusting the vscode command you cited in the test plan)

This revision is now accepted and ready to land.May 5 2022, 10:36 AM

Closed by commit rCOMM3f0af4aa3eb5: [native][refactor] sort colors in theme (authored by • benschac). · Explain WhyMay 5 2022, 11:21 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM3f0af4aa3eb5: [native][refactor] sort colors in theme.

Revision Contents
Changeset List

Path

Size

native/

themes/

colors.js

202 lines

Diff 12306

View Options

[native][refactor] sort colors in themeClosedPublicActions