Paths

Table of Contentst

Differential D3954

[web] Dispatch change notification settings action in `NotificationsModal`
ClosedPublic
Actions

Authored by • jacek on May 6 2022, 8:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 9:07 AM

	Unknown Object (File)
	Wed, Nov 13, 10:49 AM

	Unknown Object (File)
	Wed, Nov 13, 10:49 AM

	Unknown Object (File)
	Sat, Nov 9, 2:58 PM

	Unknown Object (File)
	Sat, Nov 9, 2:57 PM

	Unknown Object (File)
	Sat, Nov 9, 2:33 PM

	Unknown Object (File)
	Sat, Nov 9, 2:22 PM

	Unknown Object (File)
	Sat, Nov 9, 2:19 PM

Subscribers

Details

Reviewers

tomek
• benschac
atul

Commits

rCOMM9d502041b6d3: [web] Dispatch change notification settings action in `NotificationsModal`

Summary

Dispatch server action after clicking on save button in the notifications modal

Test Plan

Checked if the notifications settings are changed after selecting different options (e.g. by checking the tab - focus/selected)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.May 6 2022, 8:00 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 6 2022, 8:00 AM

• jacek added reviewers: • benschac, atul.May 6 2022, 8:01 AM

• jacek added a parent revision: D3953: [web] Introduce thread notification settings options in modal.

Harbormaster completed remote builds in B8866: Diff 12362.May 6 2022, 8:05 AM

• jacek requested review of this revision.May 6 2022, 8:05 AM

• jacek added a child revision: D3955: [web] Introduce `Notifications` action in thread menu.May 6 2022, 8:08 AM

atul accepted this revision.May 9 2022, 10:31 AM

atul added inline comments.

web/modals/threads/notifications/notifications-modal.react.js
145 ↗	(On Diff #12362)	nit: might be good to add a newline after the `onClickSave` block just to make it clear where it ends and the `return` statement begins

This revision is now accepted and ready to land.May 9 2022, 10:31 AM

add newline

Harbormaster completed remote builds in B8978: Diff 12488.May 10 2022, 3:45 AM

rebase

Harbormaster completed remote builds in B9064: Diff 12610.May 13 2022, 2:18 AM

Closed by commit rCOMM9d502041b6d3: [web] Dispatch change notification settings action in `NotificationsModal` (authored by • jacek). · Explain WhyMay 13 2022, 3:36 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM9d502041b6d3: [web] Dispatch change notification settings action in `NotificationsModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

notifications/

notifications-modal.react.js

33 lines

Diff 12642

web/modals/threads/notifications/notifications-modal.react.js

Loading...