Page MenuHomePhabricator
Differential D4014

[services] Remove `container_name` from docker-compose file
ClosedPublic
Actions

Authored by • max on May 12 2022, 4:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 12:00 PM
Unknown Object (File)
Wed, May 15, 8:44 AM
Unknown Object (File)
Mon, May 6, 7:34 AM
Unknown Object (File)
Fri, May 3, 5:06 PM
Unknown Object (File)
May 1 2024, 1:55 PM
Unknown Object (File)
Apr 29 2024, 8:28 AM
Unknown Object (File)
Apr 22 2024, 9:20 AM
Unknown Object (File)
Apr 20 2024, 2:35 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• jim
tomek
• karol
ashoat
Commits
rCOMM53b692443067: [services] Remove `container_name` from docker-compose file
Summary

Because Docker container names must be unique, we cannot scale a service beyond 1 container that's why we need to remove container_name from
service's docker-compose file.

Related diff: D3847

Linear task: ENG-1129

Test Plan

Run docker compose up tunnelbroker-server, docker compose up backup-server, docker compose up blob-server.

Diff Detail

Repository
rCOMM Comm
Branch
docker-compose-remove-cont-name
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.May 12 2022, 4:59 AM
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 12 2022, 4:59 AM
• max edited the summary of this revision. (Show Details)May 12 2022, 5:00 AM
• max added reviewers: • jim, tomek, • karol.
Harbormaster completed remote builds in B9033: Diff 12576.May 12 2022, 5:04 AM
• max requested review of this revision.May 12 2022, 5:04 AM
• max added a child revision: D3964: [services] Tunnelbroker - RabbitMQ Docker image for dev environment.May 12 2022, 5:06 AM
• max mentioned this in D3964: [services] Tunnelbroker - RabbitMQ Docker image for dev environment.May 12 2022, 5:10 AM
ashoat accepted this revision.May 12 2022, 12:42 PM

This looks simple so I'll just accept

tomek accepted this revision.May 13 2022, 1:52 AM
This revision is now accepted and ready to land.May 13 2022, 1:52 AM
• max updated this revision to Diff 12650.May 13 2022, 5:04 AM

Rebase on master.

Harbormaster completed remote builds in B9091: Diff 12650.May 13 2022, 5:10 AM
Closed by commit rCOMM53b692443067: [services] Remove `container_name` from docker-compose file (authored by • max). · Explain WhyMay 13 2022, 5:27 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM53b692443067: [services] Remove `container_name` from docker-compose file.

Revision Contents
Changeset List

PathSize
services/
5 lines

Diff 12650

View Options

services/docker-compose.yml

Loading...