Raised in https://phabricator.ashoat.com/D3988#112748
I mistakenly put run_service.sh instead of run_tests.sh
Details
Details
cd services yarn test-tunnelbroker-service
This should run tunnelbroker tests
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- fix-tb
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I don't know. For blob and backup I get:
blob-server_1 | /bin/sh: 1: [[: not found blob-server_1 | Server listening
backup-server_1 | /bin/sh: 1: [[: not found backup-server_1 | Server listening
So it kind of works but this error message doesn't look good. Is this really worth spending time on and investigating why on earth bash again does weird stuff with the simplest stuff?
Comment Actions
Yes, I think it matters for two reasons:
- We've had ENG-157: Make brackets consistent in bash scripts in services open for a while
- We should understand what is going on with this stuff and how it's run
So it kind of works but this error message doesn't look good. Is this really worth spending time on and investigating why on earth bash again does weird stuff with the simplest stuff?
My guess is that this isn't bash... otherwise, it would have [[. It took me <2 min of Googling to find this:
On Ubuntu systems, /bin/sh is dash, not bash, and dash does not support the double bracket keyword (or didn't at the time of this posting, I haven't double-checked).
Honestly, it probably is taking me longer to type out this essay for you than it would have taken you to simply research the issue, as requested.
This is another example of you wasting your reviewers time. I should be able to send you "can you clarify why?" and get a response back, without you re-requesting review.
Comment Actions
I then did some further research (that @karol-bisztyga should have done) to understand how CMD works. Here is what I found:
When using the shell form, the specified binary is executed with an invocation of the shell using /bin/sh -c. You can see this clearly if you run a container and then look at the docker ps output
So it seems we should consider CMD /bin/bash -c here.
Comment Actions
Raising this diff because D4751 was created as a duplicate and we need to fix this in a Tunnelbroker to run the tests from the CI.
We already have the same lines in a backup and blob Docker files. It's tested and works as expected.
This is an old diff and from that time @ashoat needs to be removed from reviewers and I think @tomek should be as blocking or I can commandeer this diff.
Comment Actions
/bin/sh: 1: [[: not found
Ubuntu uses dash for /bin/sh which is specifically not BASH compatible, it's just meant to be a fast UNIX compatible shell
# ls -l /bin/sh lrwxrwxrwx 1 root root 4 Jul 18 2019 /bin/sh -> dash