Differential D4045
[web] Rename `NotificationsOption` -> `EnumSettingsOption` Authored by atul on May 15 2022, 9:44 AM. Tags None Referenced Files
Details We want to reuse the (previously known as) NotificationsOption component for the "Privacy" tab of ThreadSettingsModal. As a first step, we rename NotificationsOption to more generic EnumSettingsOption (open to alternative names). In later diffs will remove "Notifications-specific" parts of EnumSettingsOption and make it more generic. Made sure to rename component, rename file, and fix imports. Depends on D4044 Opened NotificationsModal and it continues to look/work as expected. Also flow/eslint.
Diff Detail
Event TimelineComment Actions Not sure what will be the responsibility of these components after the refactoring, but we can always find a better name after its done. From what I understand now, the component will handle any setting, not only notification-specific. Why do you think we should start the name with enum? It sounds like SettingsOption should work ok for a generic component, but it is possible I'm missing something. Comment Actions
I couldn't think of a great name at the moment so went with Enum to match some of the names (of divs/css selectors) that were already in the ThreadSettingsPrivacyTab component. I think SettingsOption might be too generic? But still very open to suggestions since I agree it's a bit of an odd name... could add a diff at end of stack with rename if we decide on one |