Page MenuHomePhabricator
Differential D4044

[web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css`
ClosedPublic
Actions

Authored by atul on May 15 2022, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 9:42 PM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:51 AM
Unknown Object (File)
Sat, Mar 15, 4:30 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• benschac
Commits
rCOMM387806bb8d38: [web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css`
Summary

Ripping out styles that aren't going to be relevant once ThreadSettingsPrivacyTab is re-styled.

Depends on D4043

Test Plan

Before:

812d.png (758×724 px, 67 KB)

After:

32c3-1.png (784×714 px, 66 KB)

Everything continues to work as expected, doesn't really matter how it looks at this stage since it's going to be re-styled in the next diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 15 2022, 8:27 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 15 2022, 8:27 AM
atul edited the test plan for this revision. (Show Details)May 15 2022, 8:27 AM
atul updated this revision to Diff 12686.May 15 2022, 8:31 AM

remove a bit more

atul published this revision for review.May 15 2022, 8:31 AM
Harbormaster completed remote builds in B9120: Diff 12685.May 15 2022, 8:33 AM
Harbormaster completed remote builds in B9121: Diff 12686.May 15 2022, 8:36 AM
atul edited the summary of this revision. (Show Details)May 15 2022, 9:45 AM
atul added a parent revision: D4043: [web] Move `ThreadSettingsModal` and related components to new `modals/threads/settings` directory.
atul added a child revision: D4045: [web] Rename `NotificationsOption` -> `EnumSettingsOption`.
• benschac accepted this revision.May 16 2022, 6:03 AM

Going to assume that you grepped the code base for these style names, and they weren't used anywhere. If so then LGTM.

This revision is now accepted and ready to land.May 16 2022, 6:03 AM
atul added 1 blocking reviewer(s): tomek.May 16 2022, 6:14 AM
This revision now requires review to proceed.May 16 2022, 6:14 AM
tomek accepted this revision.May 16 2022, 9:49 AM

My guess is that some of the divs might be safely removed, but they probably will have some classes assigned after the redesing.

This revision is now accepted and ready to land.May 16 2022, 9:49 AM
atul added a comment.May 16 2022, 11:23 AM
In D4044#113771, @benschac wrote:

Going to assume that you grepped the code base for these style names, and they weren't used anywhere. If so then LGTM.

Yeah, made sure the stylesheet was only pulled into the ThreadSettingsPrivacyTab component.

In D4044#113913, @palys-swm wrote:

My guess is that some of the divs might be safely removed, but they probably will have some classes assigned after the redesign.

Yeah, the layout changes a good bit in subsequent diffs

atul updated this revision to Diff 12760.May 16 2022, 11:24 AM

rebase before landing

Harbormaster completed remote builds in B9174: Diff 12760.May 16 2022, 11:30 AM
Closed by commit rCOMM387806bb8d38: [web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css` (authored by atul). · Explain WhyMay 16 2022, 11:35 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM387806bb8d38: [web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css`.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
settings/
36 lines
106 lines

Diff 12761

View Options

web/modals/threads/settings/thread-settings-privacy-tab.css

Show First 20 Lines • Show All 285 Lines • ▼ Show 20 Lines | {
+messageInfoType: 'composable', +messageInfoType: 'composable',
+messageInfo: ComposableMessageInfo, +messageInfo: ComposableMessageInfo,
+localMessageInfo: ?LocalMessageInfo, +localMessageInfo: ?LocalMessageInfo,
+startsConversation: boolean, +startsConversation: boolean,
+startsCluster: boolean, +startsCluster: boolean,
endsCluster: boolean, endsCluster: boolean,
+threadCreatedFromMessage: ?ThreadInfo, +threadCreatedFromMessage: ?ThreadInfo,
+reactions: ReactionInfo, +reactions: ReactionInfo,
+hasBeenEdited: boolean,
}; };
export type ChatMessageItem = { itemType: 'loader' } | ChatMessageInfoItem; export type ChatMessageItem = { itemType: 'loader' } | ChatMessageInfoItem;
export type ReactionInfo = { +[reaction: string]: MessageReactionInfo }; export type ReactionInfo = { +[reaction: string]: MessageReactionInfo };
type MessageReactionInfo = { type MessageReactionInfo = {
+viewerReacted: boolean, +viewerReacted: boolean,
+users: $ReadOnlyArray<RelativeUserInfo>, +users: $ReadOnlyArray<RelativeUserInfo>,
}; };
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines let originalMessageInfo =
messageInfo.type === messageTypes.SIDEBAR_SOURCE messageInfo.type === messageTypes.SIDEBAR_SOURCE
? messageInfo.sourceMessage ? messageInfo.sourceMessage
: messageInfo; : messageInfo;
if (isEmptyMediaMessage(originalMessageInfo)) { if (isEmptyMediaMessage(originalMessageInfo)) {
continue; continue;
} }
let hasBeenEdited = false;
if ( if (
originalMessageInfo.type === messageTypes.TEXT && originalMessageInfo.type === messageTypes.TEXT &&
originalMessageInfo.id originalMessageInfo.id
) { ) {
const newText = targetMessageEditMap.get(originalMessageInfo.id); const newText = targetMessageEditMap.get(originalMessageInfo.id);
if (newText !== undefined) { if (newText !== undefined) {
originalMessageInfo = { ...originalMessageInfo, text: newText }; hasBeenEdited = true;
originalMessageInfo = {
...originalMessageInfo,
text: newText,
};
} }
} }
let startsConversation = true; let startsConversation = true;
let startsCluster = true; let startsCluster = true;
if ( if (
lastMessageInfo && lastMessageInfo &&
lastMessageInfo.time + msInFiveMinutes > originalMessageInfo.time lastMessageInfo.time + msInFiveMinutes > originalMessageInfo.time
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (isComposableMessageType(originalMessageInfo.type)) {
messageInfoType: 'composable', messageInfoType: 'composable',
messageInfo: originalMessageInfo, messageInfo: originalMessageInfo,
localMessageInfo, localMessageInfo,
startsConversation, startsConversation,
startsCluster, startsCluster,
endsCluster: false, endsCluster: false,
threadCreatedFromMessage, threadCreatedFromMessage,
reactions: renderedReactions, reactions: renderedReactions,
hasBeenEdited,
}); });
} else { } else {
invariant( invariant(
originalMessageInfo.type !== messageTypes.TEXT && originalMessageInfo.type !== messageTypes.TEXT &&
originalMessageInfo.type !== messageTypes.IMAGES && originalMessageInfo.type !== messageTypes.IMAGES &&
originalMessageInfo.type !== messageTypes.MULTIMEDIA, originalMessageInfo.type !== messageTypes.MULTIMEDIA,
"Flow doesn't understand isComposableMessageType above", "Flow doesn't understand isComposableMessageType above",
); );
▲ Show 20 Lines • Show All 134 Lines • Show Last 20 Lines
View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Show First 20 Lines • Show All 285 Lines • ▼ Show 20 Lines | {
+messageInfoType: 'composable', +messageInfoType: 'composable',
+messageInfo: ComposableMessageInfo, +messageInfo: ComposableMessageInfo,
+localMessageInfo: ?LocalMessageInfo, +localMessageInfo: ?LocalMessageInfo,
+startsConversation: boolean, +startsConversation: boolean,
+startsCluster: boolean, +startsCluster: boolean,
endsCluster: boolean, endsCluster: boolean,
+threadCreatedFromMessage: ?ThreadInfo, +threadCreatedFromMessage: ?ThreadInfo,
+reactions: ReactionInfo, +reactions: ReactionInfo,
+hasBeenEdited: boolean,
}; };
export type ChatMessageItem = { itemType: 'loader' } | ChatMessageInfoItem; export type ChatMessageItem = { itemType: 'loader' } | ChatMessageInfoItem;
export type ReactionInfo = { +[reaction: string]: MessageReactionInfo }; export type ReactionInfo = { +[reaction: string]: MessageReactionInfo };
type MessageReactionInfo = { type MessageReactionInfo = {
+viewerReacted: boolean, +viewerReacted: boolean,
+users: $ReadOnlyArray<RelativeUserInfo>, +users: $ReadOnlyArray<RelativeUserInfo>,
}; };
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines let originalMessageInfo =
messageInfo.type === messageTypes.SIDEBAR_SOURCE messageInfo.type === messageTypes.SIDEBAR_SOURCE
? messageInfo.sourceMessage ? messageInfo.sourceMessage
: messageInfo; : messageInfo;
if (isEmptyMediaMessage(originalMessageInfo)) { if (isEmptyMediaMessage(originalMessageInfo)) {
continue; continue;
} }
let hasBeenEdited = false;
if ( if (
originalMessageInfo.type === messageTypes.TEXT && originalMessageInfo.type === messageTypes.TEXT &&
originalMessageInfo.id originalMessageInfo.id
) { ) {
const newText = targetMessageEditMap.get(originalMessageInfo.id); const newText = targetMessageEditMap.get(originalMessageInfo.id);
if (newText !== undefined) { if (newText !== undefined) {
originalMessageInfo = { ...originalMessageInfo, text: newText }; hasBeenEdited = true;
originalMessageInfo = {
...originalMessageInfo,
text: newText,
};
} }
} }
let startsConversation = true; let startsConversation = true;
let startsCluster = true; let startsCluster = true;
if ( if (
lastMessageInfo && lastMessageInfo &&
lastMessageInfo.time + msInFiveMinutes > originalMessageInfo.time lastMessageInfo.time + msInFiveMinutes > originalMessageInfo.time
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (isComposableMessageType(originalMessageInfo.type)) {
messageInfoType: 'composable', messageInfoType: 'composable',
messageInfo: originalMessageInfo, messageInfo: originalMessageInfo,
localMessageInfo, localMessageInfo,
startsConversation, startsConversation,
startsCluster, startsCluster,
endsCluster: false, endsCluster: false,
threadCreatedFromMessage, threadCreatedFromMessage,
reactions: renderedReactions, reactions: renderedReactions,
hasBeenEdited,
}); });
} else { } else {
invariant( invariant(
originalMessageInfo.type !== messageTypes.TEXT && originalMessageInfo.type !== messageTypes.TEXT &&
originalMessageInfo.type !== messageTypes.IMAGES && originalMessageInfo.type !== messageTypes.IMAGES &&
originalMessageInfo.type !== messageTypes.MULTIMEDIA, originalMessageInfo.type !== messageTypes.MULTIMEDIA,
"Flow doesn't understand isComposableMessageType above", "Flow doesn't understand isComposableMessageType above",
); );
▲ Show 20 Lines • Show All 134 Lines • Show Last 20 Lines