Paths

Table of Contentst

Differential D4044

[web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css`
ClosedPublic
Actions

Authored by atul on May 15 2022, 8:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 7:29 PM

	Unknown Object (File)
	Sat, Nov 9, 7:09 PM

	Unknown Object (File)
	Sat, Nov 9, 7:04 PM

	Unknown Object (File)
	Sat, Nov 9, 6:03 PM

	Unknown Object (File)
	Sat, Nov 9, 4:59 PM

	Unknown Object (File)
	Sat, Nov 9, 10:40 AM

	Unknown Object (File)
	Oct 21 2024, 8:21 PM

	Unknown Object (File)
	Oct 4 2024, 9:25 AM

Subscribers

Details

Reviewers

• jacek
tomek
• benschac

Commits

rCOMM387806bb8d38: [web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css`

Summary

Ripping out styles that aren't going to be relevant once ThreadSettingsPrivacyTab is re-styled.

Depends on D4043

Test Plan

Before:

812d.png (758×724 px, 67 KB)

After:

32c3-1.png (784×714 px, 66 KB)

Everything continues to work as expected, doesn't really matter how it looks at this stage since it's going to be re-styled in the next diffs.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 15 2022, 8:27 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 15 2022, 8:27 AM

atul edited the test plan for this revision. (Show Details)May 15 2022, 8:27 AM

remove a bit more

atul published this revision for review.May 15 2022, 8:31 AM

Harbormaster completed remote builds in B9120: Diff 12685.May 15 2022, 8:33 AM

Harbormaster completed remote builds in B9121: Diff 12686.May 15 2022, 8:36 AM

atul edited the summary of this revision. (Show Details)May 15 2022, 9:45 AM

atul added a parent revision: D4043: [web] Move `ThreadSettingsModal` and related components to new `modals/threads/settings` directory.

atul added a child revision: D4045: [web] Rename `NotificationsOption` -> `EnumSettingsOption`.

Going to assume that you grepped the code base for these style names, and they weren't used anywhere. If so then LGTM.

This revision is now accepted and ready to land.May 16 2022, 6:03 AM

atul added 1 blocking reviewer(s): tomek.May 16 2022, 6:14 AM

This revision now requires review to proceed.May 16 2022, 6:14 AM

My guess is that some of the divs might be safely removed, but they probably will have some classes assigned after the redesing.

This revision is now accepted and ready to land.May 16 2022, 9:49 AM

In D4044#113771, @benschac wrote:

Going to assume that you grepped the code base for these style names, and they weren't used anywhere. If so then LGTM.

Yeah, made sure the stylesheet was only pulled into the ThreadSettingsPrivacyTab component.

In D4044#113913, @palys-swm wrote:

My guess is that some of the divs might be safely removed, but they probably will have some classes assigned after the redesign.

Yeah, the layout changes a good bit in subsequent diffs

rebase before landing

Harbormaster completed remote builds in B9174: Diff 12760.May 16 2022, 11:30 AM

Closed by commit rCOMM387806bb8d38: [web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css` (authored by atul). · Explain WhyMay 16 2022, 11:35 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM387806bb8d38: [web] Cut extraneous/unused styles from `thread-settings-privacy-tab.css`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

settings/

thread-settings-privacy-tab.css

36 lines

thread-settings-privacy-tab.react.js

106 lines

Diff 12761

web/modals/threads/settings/thread-settings-privacy-tab.css

Loading...

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...