Page MenuHomePhabricator
Differential D4049

[web] Move `EnumSettingsOption[Info]` components to `/components`
ClosedPublic
Actions

Authored by atul on May 15 2022, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 5:43 AM
Unknown Object (File)
Mon, Nov 25, 5:38 AM
Unknown Object (File)
Sat, Nov 23, 3:18 PM
Unknown Object (File)
Thu, Nov 14, 10:21 AM
Unknown Object (File)
Thu, Nov 14, 10:21 AM
Unknown Object (File)
Thu, Nov 14, 10:21 AM
Unknown Object (File)
Thu, Nov 14, 10:21 AM
Unknown Object (File)
Wed, Nov 13, 4:00 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• benschac
Commits
rCOMM989a5b1daf74: [web] Move `EnumSettingsOption[Info]` components to `/components`
Summary

Can move these to components since they're now "generic" and can be used elsewhere (eg for the ThreadSettingsPrivacyTab)

Depends on D4048

Test Plan
  1. Open NotificationsModal
  2. Make sure everything still looks/works as expected

Diff Detail

Repository
rCOMM Comm
Branch
landmay19 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 15 2022, 12:30 PM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 15 2022, 12:30 PM
atul edited the summary of this revision. (Show Details)May 15 2022, 12:36 PM
atul added a parent revision: D4048: [web] Replace `EnumSettingsOption` `description` prop with `statements` prop.
Harbormaster completed remote builds in B9129: Diff 12694.May 15 2022, 12:36 PM
atul requested review of this revision.May 15 2022, 12:36 PM
tomek accepted this revision.May 17 2022, 6:29 AM
This revision is now accepted and ready to land.May 17 2022, 6:29 AM
atul added a child revision: D4050: [web] Pass `optionSelected` from `EnumSettingsOption` to `EnumSettingsOptionInfo`.May 17 2022, 7:13 AM
atul updated this revision to Diff 12953.May 19 2022, 8:05 AM

rebase after resolving merge conflicts and before landign

Harbormaster completed remote builds in B9350: Diff 12953.May 19 2022, 8:11 AM
Closed by commit rCOMM989a5b1daf74: [web] Move `EnumSettingsOption[Info]` components to `/components` (authored by atul). · Explain WhyMay 19 2022, 8:26 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM989a5b1daf74: [web] Move `EnumSettingsOption[Info]` components to `/components`.

Revision Contents
Changeset List

Diff 12953

View Options

web/components/enum-settings-option-info.css

Loading...
View Options

web/components/enum-settings-option-info.react.js

Loading...
View Options

web/components/enum-settings-option.css

Loading...
View Options

web/components/enum-settings-option.react.js

Loading...
View Options

web/modals/threads/notifications/enum-settings-option-info.css

Loading...
View Options

web/modals/threads/notifications/enum-settings-option-info.react.js

Loading...
View Options

web/modals/threads/notifications/enum-settings-option.css

Loading...
View Options

web/modals/threads/notifications/enum-settings-option.react.js

Loading...
View Options

web/modals/threads/notifications/notifications-modal.react.js

Loading...