This is a minimally-viable first pass.
Replace the inputs in ThreadSettingsPrivacyTab with EnumSettingOptions. There is still a good bit to go with stying, but should be functionally complete.
Here's how it looks:
Depends on D4050
Details
Details
Click around, change visibility, observe that things look/behave as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- landmay19 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/modals/threads/settings/thread-settings-privacy-tab.react.js | ||
|---|---|---|
| 33 ↗ | (On Diff #12696) | Will probably type these as maybe instead of optional in subsequent diff to avoid having to explicitly write undefined here |
| 114 ↗ | (On Diff #12696) | Lack of disabled prop is a "known issue," will be addressed later in this stack. |
| web/modals/threads/settings/thread-settings-privacy-tab.react.js | ||
|---|---|---|
| 104–122 ↗ | (On Diff #12697) | could probably introduce a third "general" callback to cut repetition here |
| web/components/enum-settings-option-info.css | ||
|---|---|---|
| 5 ↗ | (On Diff #12697) | Yeah, you're right that this is hacky and specifically to get ThreadSettingsPrivacyTab to look right. Will find a better approach here that's more general |
| web/modals/threads/settings/thread-settings-privacy-tab.react.js | ||
| 105 ↗ | (On Diff #12697) | Good point, there's no longer a reason. We were previously asserting that event.currentTarget.value was a threadType, but that's not longer relevant. Will update. |