Page MenuHomePhabricator
Differential D4109

[web] Pull "statement" constants out of `NotificationsModal`
ClosedPublic
Actions

Authored by atul on May 23 2022, 2:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 6:56 PM
Unknown Object (File)
Tue, Apr 8, 6:53 PM
Unknown Object (File)
Tue, Apr 8, 6:18 PM
Unknown Object (File)
Tue, Apr 8, 5:23 PM
Unknown Object (File)
Tue, Apr 8, 7:36 AM
Unknown Object (File)
Fri, Apr 4, 7:12 PM
Unknown Object (File)
Fri, Apr 4, 7:12 PM
Unknown Object (File)
Fri, Apr 4, 7:11 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
tomek

Details

Reviewers
• jacek
tomek
• benschac
Commits
rCOMM273f666112ca: [web] Pull "statement" constants out of `NotificationsModal`
Summary

Addresses feedback from @palys-swm in D4048: https://phabricator.ashoat.com/D4048#114268
Linear Issue: https://linear.app/comm/issue/ENG-1173/pull-statement-constants-out-of-notificationsmodal

Test Plan

Open NotificationsModal and ensure that things continue to look as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
notifications/
45 lines

Diff 13022

View Options

web/modals/threads/notifications/notifications-modal.react.js

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Linesconst tPlatform: TEnums = t.enums.of([
'windows', 'windows',
'macos', 'macos',
]); ]);
const tDeviceType: TEnums = t.enums.of(['ios', 'android']); const tDeviceType: TEnums = t.enums.of(['ios', 'android']);
const tPlatformDetails: TInterface<PlatformDetails> = tShape({ const tPlatformDetails: TInterface<PlatformDetails> = tShape({
platform: tPlatform, platform: tPlatform,
codeVersion: t.maybe(t.Number), codeVersion: t.maybe(t.Number),
stateVersion: t.maybe(t.Number), stateVersion: t.maybe(t.Number),
majorDesktopVersion: t.maybe(t.Number),
}); });
const tPassword: TRefinement<string> = t.refinement( const tPassword: TRefinement<string> = t.refinement(
t.String, t.String,
(password: string) => !!password, (password: string) => !!password,
); );
const tCookie: TRegex = tRegex(/^(user|anonymous)=[0-9]+:[0-9a-f]+$/); const tCookie: TRegex = tRegex(/^(user|anonymous)=[0-9]+:[0-9a-f]+$/);
const tEmail: TRegex = tRegex(validEmailRegex); const tEmail: TRegex = tRegex(validEmailRegex);
const tOldValidUsername: TRegex = tRegex(oldValidUsernameRegex); const tOldValidUsername: TRegex = tRegex(oldValidUsernameRegex);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines