Page MenuHomePhabricator
Differential D4134

[services] Backup - Database Items - Update attachment methods
ClosedPublic
Actions

Authored by • karol on May 26 2022, 3:06 AM.
Tags
None
Referenced Files
F2837624: D4134.id13142.diff
Sat, Sep 28, 7:20 PM
Unknown Object (File)
Mon, Sep 23, 8:23 PM
Unknown Object (File)
Wed, Sep 18, 12:12 PM
Unknown Object (File)
Tue, Sep 3, 5:05 AM
Unknown Object (File)
Tue, Sep 3, 5:05 AM
Unknown Object (File)
Tue, Sep 3, 5:05 AM
Unknown Object (File)
Tue, Sep 3, 5:05 AM
Unknown Object (File)
Tue, Sep 3, 5:01 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMMb1e5cf1be08c: [services] Backup - Database Items - Update attachment methods
Summary

Depends on D4133

Renaming appendAttachmentHolder to addAttachmentHolders for consistency and using tools::parseAttachmentHolders in both BackupItem and LogItem.

Test Plan

Services can still be built normally. For a full test plan of this functionality, please see D4135

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 26 2022, 3:06 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 26 2022, 3:06 AM
• karol edited the summary of this revision. (Show Details)May 26 2022, 3:15 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4133: [services] Backup - Tools - validate attachment holders.
• karol added a child revision: D4135: [services] Backup - Add Attachment Reactor Logic.May 26 2022, 3:25 AM
Harbormaster completed remote builds in B9488: Diff 13142.May 26 2022, 3:26 AM
• karol requested review of this revision.May 26 2022, 3:26 AM
• karol planned changes to this revision.May 27 2022, 6:45 AM
• karol updated this revision to Diff 13156.May 27 2022, 6:46 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)

rebase

Harbormaster completed remote builds in B9502: Diff 13156.May 27 2022, 6:58 AM
tomek accepted this revision.May 30 2022, 4:44 AM
This revision is now accepted and ready to land.May 30 2022, 4:44 AM
Closed by commit rCOMMb1e5cf1be08c: [services] Backup - Database Items - Update attachment methods (authored by • karol). · Explain WhyMay 30 2022, 9:13 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMb1e5cf1be08c: [services] Backup - Database Items - Update attachment methods.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
DatabaseEntities/
2 lines
7 lines
2 lines
7 lines

Diff 13142

View Options

services/backup/src/DatabaseEntities/BackupItem.h

Loading...
View Options

services/backup/src/DatabaseEntities/BackupItem.cpp

Loading...
View Options

services/backup/src/DatabaseEntities/LogItem.h

Loading...
View Options

services/backup/src/DatabaseEntities/LogItem.cpp

Loading...