Page MenuHomePhabricator

[DRAFT] [services] Tests - Add to docker compose
AbandonedPublic

Authored by karol on May 31 2022, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:22 PM
Unknown Object (File)
Fri, Dec 20, 12:34 PM
Unknown Object (File)
Fri, Dec 20, 12:34 PM
Unknown Object (File)
Fri, Dec 20, 12:34 PM
Unknown Object (File)
Fri, Dec 20, 12:32 PM
Unknown Object (File)
Thu, Dec 19, 4:05 AM
Unknown Object (File)
Wed, Dec 18, 10:42 PM
Unknown Object (File)
Nov 18 2024, 10:30 AM

Details

Reviewers
tomek
varun
ashoat
Summary

Depends on D4162

Adding docker-compose for the testing service. Nothing fancy here, mostly copied from the other services.

Test Plan
cd services
docker-compose up commtest-server

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 31 2022, 6:54 AM
Harbormaster failed remote builds in B9542: Diff 13236!
karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, ashoat, varun.
Harbormaster returned this revision to the author for changes because remote builds failed.May 31 2022, 7:26 AM
Harbormaster failed remote builds in B9554: Diff 13248!

I know that Ci failed but it's related to docker which I know is not working properly right now.

Seems good to me, but I'm a bit confused about why we need Docker. Resigning here – we can discuss in D4161

LGTM, but also curious if we really need to Dockerize our testing service

This revision is now accepted and ready to land.Jun 1 2022, 9:54 AM

Yes, we can resign from docker here I think.