[keyserver] Fix emojis in MySQL backups
ClosedPublic
Actions

Authored by ashoat on Jun 1 2022, 1:33 AM.

Details

Reviewers

tomek
atul

Commits

rCOMM87c22af3d8ab: [keyserver] Fix emojis in MySQL backups

Summary

When I tested restoring my keyserver backup on my laptop, I noticed that all of the emojis were broken. I did some Googling and found some results that together pointed at this solution.

Depends on D4176

Test Plan

Backup my keyserver DB on server and then restore on my laptop

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 1 2022, 1:33 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJun 1 2022, 1:33 AM

ashoat added a child revision: D4178: [keyserver] Run Docker as non-root user.Jun 1 2022, 2:15 AM

Harbormaster completed remote builds in B9572: Diff 13270.Jun 1 2022, 2:32 AM

ashoat requested review of this revision.Jun 1 2022, 2:32 AM

Weird that this doesn't get picked up from MySQL.. we specify DEFAULT CHARSET for the messages/threads/etc table in setup-db.js

This revision is now accepted and ready to land.Jun 1 2022, 8:01 AM

Yeah, super weird. The people in the Twitter thread linked above had the exact same comment...

Closed by commit rCOMM87c22af3d8ab: [keyserver] Fix emojis in MySQL backups (authored by ashoat). · Explain WhyJun 1 2022, 10:56 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM87c22af3d8ab: [keyserver] Fix emojis in MySQL backups.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

backups.js

1 line

Diff 13270

View Options

keyserver/src/cron/backups.js

[keyserver] Fix emojis in MySQL backupsClosedPublicActions