[keyserver] Cache Webpack builds in Docker build
ClosedPublic
Actions

Authored by ashoat on Jun 1 2022, 1:32 AM.

Details

Reviewers

tomek
atul

Commits

rCOMMe6b753998cee: [keyserver] Cache Webpack builds in Docker build

Summary

I'm iterating on files in the keyserver directory, and every time I rebuild the Docker image the Webpack builds get re-run, even though none of the files they depend on have changed.

This diff makes sure that the Webpack builds only get rerun if one of the files they depend on changes.

Depends on D4174

Test Plan

I observed that the Webpack builds stopped appearing on every Docker build after this diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 1 2022, 1:32 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJun 1 2022, 1:32 AM

ashoat added a child revision: D4176: [keyserver] Add MySQL config to mirror production server.Jun 1 2022, 1:33 AM

Harbormaster completed remote builds in B9570: Diff 13268.Jun 1 2022, 2:10 AM

ashoat requested review of this revision.Jun 1 2022, 2:10 AM

atul accepted this revision.Jun 1 2022, 7:35 AM

This revision is now accepted and ready to land.Jun 1 2022, 7:35 AM

ashoat mentioned this in D4172: [keyserver] Add Webpack builds to keyserver Dockerfile.Jun 1 2022, 9:48 AM

Closed by commit rCOMMe6b753998cee: [keyserver] Cache Webpack builds in Docker build (authored by ashoat). · Explain WhyJun 1 2022, 10:56 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe6b753998cee: [keyserver] Cache Webpack builds in Docker build.

Revision Contents
Changeset List

Path

Size

keyserver/

Dockerfile

26 lines

Diff 13284

View Options

[keyserver] Cache Webpack builds in Docker buildClosedPublicActions