Page MenuHomePhabricator

[lib] Update `threadStore` with `threadStoreOps` for logIn/registerActionTypes.success/fullStateSync actions
ClosedPublic

Authored by atul on Jun 2 2022, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 5:00 PM
Unknown Object (File)
Oct 8 2024, 8:51 AM
Unknown Object (File)
Oct 8 2024, 8:51 AM
Unknown Object (File)
Oct 8 2024, 8:51 AM
Unknown Object (File)
Oct 8 2024, 8:51 AM
Unknown Object (File)
Oct 8 2024, 8:50 AM
Unknown Object (File)
Oct 8 2024, 8:50 AM
Unknown Object (File)
Oct 8 2024, 8:50 AM

Details

Summary

Previously we were directly updating the threadStore object with the necessary changes for each action... and also constructing a corresponding list of ops that were used for modifying the SQLite store (on native).

We've had an assertThreadStoreThreadsAreEqual check for each action to verify that the threadStore being constructed "directly" and via the "ops approach" were equivalent. At this point we're pretty confident that they are, and so can safely remove some of the redundant code.

In this diff we remove the assertThreadStoreThreadsAreEqual and return the "processed" threadStore as the "updated" threadStore.

Test Plan

Hopefully the months of having assertThreadStoreThreadsAreEqual check in are sufficient.

Diff Detail

Repository
rCOMM Comm
Branch
landjune7 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Jun 2 2022, 10:28 AM
This revision is now accepted and ready to land.Jun 3 2022, 2:18 AM

cherrypick before landing

see if CI gets kicked off

see if buildkite can successfully send build.finished webook to phabricato