Page MenuHomePhabricator

[lib] Update `threadStore` with `threadStoreOps` for joinThread.success/leaveThread.success/deleteThread.success/etc actions
ClosedPublic

Authored by atul on Jun 2 2022, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 2:29 PM
Unknown Object (File)
Wed, Nov 27, 1:04 PM
Unknown Object (File)
Wed, Nov 27, 1:03 PM
Unknown Object (File)
Sat, Nov 23, 7:36 PM
Unknown Object (File)
Sat, Nov 23, 5:36 PM
Unknown Object (File)
Sat, Nov 2, 5:00 PM
Unknown Object (File)
Oct 23 2024, 11:46 AM
Unknown Object (File)
Oct 23 2024, 2:29 AM

Details

Summary

Copied from D4185:

Previously we were directly updating the threadStore object with the necessary changes for each action... and also constructing a corresponding list of ops that were used for modifying the SQLite store (on native).

We've had an assertThreadStoreThreadsAreEqual check for each action to verify that the threadStore being constructed "directly" and via the "ops approach" were equivalent. At this point we're pretty confident that they are, and so can safely remove some of the redundant code.

In this diff we remove the assertThreadStoreThreadsAreEqual and return the "processed" threadStore as the "updated" threadStore.


Depends on D4186

Test Plan

Hopefully the months of having assertThreadStoreThreadsAreEqual check in are sufficient.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable