Page MenuHomePhabricator
Differential D4197

[lib] Exclusively use "ops approach" in `reduceThreadUpdates`
ClosedPublic
Actions

Authored by atul on Jun 2 2022, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 10:25 PM
Unknown Object (File)
Sat, Nov 23, 7:44 PM
Unknown Object (File)
Sat, Nov 23, 6:03 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Sat, Nov 2, 3:14 PM
Unknown Object (File)
Oct 25 2024, 7:29 PM
Unknown Object (File)
Oct 25 2024, 2:30 AM
Unknown Object (File)
Oct 21 2024, 6:39 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
tomek
Commits
rCOMMb55b818e7339: [lib] Exclusively use "ops approach" in `reduceThreadUpdates`
Summary

reduceThreadUpdates used to return both an updated threadStore object and corresponding threadStoreOperations. reduceThreadUpdates has a single callsite and that's in reduceThreadStore where only the threadStoreOperations property of the returned object was being pulled out anyways... so in this diff we remove the updated object to clean things up.

(Since this function is no longer really a "reducer," we'll rename this to something like generateOpsForThreadUpdates)

Depends on D4196

Test Plan

assertThreadStoreThreadsAreEqual hasn't flagged anything since it's been included in staff builds so we can assume "the ops are good."

Diff Detail

Repository
rCOMM Comm
Branch
landjune7 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 2 2022, 3:37 PM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 2 2022, 3:37 PM
atul added a child revision: D4198: [lib] Rename `reduceThreadUpdates` => `generateOpsForThreadUpdates`.Jun 2 2022, 3:41 PM
Harbormaster completed remote builds in B9602: Diff 13312.Jun 2 2022, 3:44 PM
atul requested review of this revision.Jun 2 2022, 3:44 PM
tomek accepted this revision.Jun 3 2022, 2:57 AM
tomek added inline comments.
lib/reducers/thread-reducer.js
132–135 ↗(On Diff #13312)

We should be able to always return threadOperations, right? If !someThreadUpdated it would be simply [].

This revision is now accepted and ready to land.Jun 3 2022, 2:57 AM
atul updated this revision to Diff 13422.Jun 8 2022, 2:12 AM

cherrypick before addressing feedback

Harbormaster completed remote builds in B9684: Diff 13422.Jun 8 2022, 2:17 AM
atul updated this revision to Diff 13423.Jun 8 2022, 2:24 AM

address feedback

Harbormaster completed remote builds in B9685: Diff 13423.Jun 8 2022, 2:29 AM
Closed by commit rCOMMb55b818e7339: [lib] Exclusively use "ops approach" in `reduceThreadUpdates` (authored by atul). · Explain WhyJun 8 2022, 5:28 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb55b818e7339: [lib] Exclusively use "ops approach" in `reduceThreadUpdates`.

Revision Contents
Changeset List

PathSize
lib/
reducers/
25 lines

Diff 13423

View Options

lib/reducers/thread-reducer.js

Loading...