Page MenuHomePhabricator
Differential D4234

Prepare SQLiteQueryExecutor for single thread retrieval
ClosedPublic
Actions

Authored by marcin on Jun 7 2022, 6:56 AM.
Tags
None
Referenced Files
F3379820: D4234.id13435.diff
Wed, Nov 27, 7:27 PM
Unknown Object (File)
Sun, Nov 24, 9:43 PM
Unknown Object (File)
Sun, Nov 24, 9:43 PM
Unknown Object (File)
Sun, Nov 24, 9:43 PM
Unknown Object (File)
Sun, Nov 24, 9:43 PM
Unknown Object (File)
Sun, Nov 24, 4:11 AM
Unknown Object (File)
Sun, Nov 24, 3:09 AM
Unknown Object (File)
Sun, Nov 24, 2:44 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
varun
Commits
rCOMM3ec3e117814a: Prepare SQLiteQueryExecutor for single thread retrieval
Summary

This diff extends SQLiteQueryExecutor API to include method to retrieve single thread based on its ID

Test Plan

No testing plan. Further diffs will use this functionality and provide appropriate testing plan.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jun 7 2022, 6:56 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 7 2022, 6:56 AM
marcin added a child revision: D4235: Implement C++ code to update thread unread status.Jun 7 2022, 7:01 AM
Harbormaster completed remote builds in B9663: Diff 13390.Jun 7 2022, 7:30 AM
marcin requested review of this revision.Jun 7 2022, 7:30 AM
tomek accepted this revision.Jun 8 2022, 6:24 AM
This revision is now accepted and ready to land.Jun 8 2022, 6:24 AM
marcin updated this revision to Diff 13435.Jun 8 2022, 6:44 AM

Rebase to master after CI change

Harbormaster completed remote builds in B9694: Diff 13435.Jun 8 2022, 7:03 AM
marcin updated this revision to Diff 13588.Jun 20 2022, 2:48 AM

Rebase master

Harbormaster completed remote builds in B9824: Diff 13588.Jun 20 2022, 3:03 AM
Closed by commit rCOMM3ec3e117814a: Prepare SQLiteQueryExecutor for single thread retrieval (authored by marcin). · Explain WhyJun 20 2022, 3:31 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3ec3e117814a: Prepare SQLiteQueryExecutor for single thread retrieval.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line
1 line
5 lines

Diff 13599

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...