Page MenuHomePhabricator
Differential D4236

Implement JNI interface to use C++ code to update thread unread status on Android
ClosedPublic
Actions

Authored by marcin on Jun 7 2022, 7:03 AM.
Tags
None
Referenced Files
F3358050: D4236.id13426.diff
Sun, Nov 24, 3:10 AM
F3358030: D4236.id13392.diff
Sun, Nov 24, 3:02 AM
F3357700: D4236.diff
Sun, Nov 24, 1:05 AM
Unknown Object (File)
Sat, Nov 2, 1:50 PM
Unknown Object (File)
Oct 19 2024, 8:31 PM
Unknown Object (File)
Oct 7 2024, 1:58 PM
Unknown Object (File)
Oct 7 2024, 1:58 PM
Unknown Object (File)
Oct 7 2024, 1:58 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
varun
Commits
rCOMMb2dcbb3425a1: Implement JNI interface to use C++ code to update thread unread status on…
Summary

Implement JNI files to expose C++ thread update functionality to CommNotificationsHandler.java

Test Plan

No testing plan. Child differential will use those files to update thread unread status in CommNotificationsHandler and will provide testing plan.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jun 7 2022, 7:03 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 7 2022, 7:03 AM
marcin added a parent revision: D4235: Implement C++ code to update thread unread status.Jun 7 2022, 7:04 AM
marcin added a child revision: D4237: Update thread unread status from CommNotificationsHandler on Android.Jun 7 2022, 7:08 AM
Harbormaster completed remote builds in B9665: Diff 13392.Jun 7 2022, 7:32 AM
marcin requested review of this revision.Jun 7 2022, 7:32 AM
ashoat added a comment.Jun 7 2022, 3:55 PM

Great work figuring this all out... the JNI stuff is not easyI

native/android/app/src/cpp/ThreadOperationsJNIHelper.cpp
13 ↗(On Diff #13392)

I assume it's okay to call initialize multiple times? (Eg. initialize is idempotent)

marcin added inline comments.Jun 8 2022, 1:49 AM
native/android/app/src/cpp/ThreadOperationsJNIHelper.cpp
13 ↗(On Diff #13392)

Yes! SQLiteQueryExecutor::initialize uses std::call_once so it is idempotent.

marcin updated this revision to Diff 13426.Jun 8 2022, 3:05 AM

Add new lines

Harbormaster completed remote builds in B9688: Diff 13426.Jun 8 2022, 3:16 AM
marcin updated this revision to Diff 13437.Jun 8 2022, 6:45 AM

Rebase to master after CI change

tomek accepted this revision.Jun 8 2022, 7:09 AM
tomek added inline comments.
native/android/app/src/cpp/ThreadOperationsJNIHelper.cpp
8–9 ↗(On Diff #13437)

Could you check if it is possible to use std::string as a parameter. According to https://github.com/facebookincubator/fbjni/blob/main/docs/quickref.md#methods-using-java-strings it seems like it might be possible.

10 ↗(On Diff #13437)

It's nice that we can use bool directly

This revision is now accepted and ready to land.Jun 8 2022, 7:09 AM
Harbormaster completed remote builds in B9696: Diff 13437.Jun 8 2022, 7:12 AM
marcin updated this revision to Diff 13442.Jun 8 2022, 7:57 AM

Use std::string in JNI files instead of facebook::jni::JString

Harbormaster failed remote builds in B9701: Diff 13442!Jun 8 2022, 8:19 AM
Harbormaster completed remote builds in B9701: Diff 13442.Jun 14 2022, 4:18 AM
marcin updated this revision to Diff 13590.Jun 20 2022, 2:49 AM

Rebase master

Harbormaster completed remote builds in B9826: Diff 13590.Jun 20 2022, 3:13 AM
Closed by commit rCOMMb2dcbb3425a1: Implement JNI interface to use C++ code to update thread unread status on… (authored by marcin). · Explain WhyJun 20 2022, 3:31 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMb2dcbb3425a1: Implement JNI interface to use C++ code to update thread unread status on….

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
cpp/
22 lines
2 lines
main/
java/
app/
comm/
android/
fbjni/
8 lines
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
ThreadOperationsUtilities/
18 lines

Diff 13601

View Options

native/android/app/src/cpp/ThreadOperationsJNIHelper.cpp

Loading...
View Options

native/android/app/src/cpp/jsiInstaller.cpp

Loading...
View Options

native/android/app/src/main/java/app/comm/android/fbjni/ThreadOperations.java

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/ThreadOperationsUtilities/ThreadOperationsJNIHelper.h

Loading...