Page MenuHomePhabricator
Differential D4330

[lib] Update `messageStore.messages` with `msgStoreOps` for `sendText/MultimediaMessage.started` actions
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 1:47 PM.
Tags
None
Referenced Files
F2907571: D4330.diff
Sun, Oct 6, 11:21 AM
Unknown Object (File)
Wed, Oct 2, 8:45 AM
Unknown Object (File)
Tue, Oct 1, 12:00 PM
Unknown Object (File)
Tue, Oct 1, 12:00 PM
Unknown Object (File)
Tue, Oct 1, 12:00 PM
Unknown Object (File)
Tue, Oct 1, 12:00 PM
Unknown Object (File)
Tue, Oct 1, 11:59 AM
Unknown Object (File)
Mon, Sep 30, 6:35 AM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• abosh
Commits
rCOMM376727a70d25: [lib] Update `messageStore.messages` with `msgStoreOps` for…
Summary

Broke this into its own diff since it's a little more involved. Basically continuing refactoring work to get to the point where we can remove assertMessageStoreMessagesAreEqual and solely use the "ops" to update messageStore.messages in redux.

Test Plan

This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 1:47 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 1:47 PM
Harbormaster completed remote builds in B9893: Diff 13685.Jun 22 2022, 1:52 PM
atul requested review of this revision.Jun 22 2022, 1:52 PM
atul mentioned this in D4331: [lib] Update `messageStore.messages` with `msgStoreOps` for remaining action types.Jun 22 2022, 2:24 PM
atul added a child revision: D4331: [lib] Update `messageStore.messages` with `msgStoreOps` for remaining action types.Jun 22 2022, 2:43 PM
tomek accepted this revision.Jun 23 2022, 3:33 AM
This revision is now accepted and ready to land.Jun 23 2022, 3:33 AM
atul updated this revision to Diff 13744.Jun 23 2022, 7:17 PM

rebase after cherrypicking and before landing

Harbormaster completed remote builds in B9941: Diff 13744.Jun 23 2022, 7:22 PM
Closed by commit rCOMM376727a70d25: [lib] Update `messageStore.messages` with `msgStoreOps` for… (authored by atul). · Explain WhyJun 23 2022, 7:41 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM376727a70d25: [lib] Update `messageStore.messages` with `msgStoreOps` for….

Revision Contents
Changeset List

PathSize
lib/
reducers/
45 lines

Diff 13745

View Options

lib/reducers/message-reducer.js

Loading...