Page MenuHomePhabricator
Differential D4331

[lib] Update `messageStore.messages` with `msgStoreOps` for remaining action types
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 2:24 PM.
Tags
None
Referenced Files
F3268566: D4331.id13686.diff
Sat, Nov 16, 3:27 AM
F3266389: D4331.diff
Sat, Nov 16, 2:02 AM
Unknown Object (File)
Thu, Nov 7, 9:43 AM
Unknown Object (File)
Thu, Nov 7, 5:18 AM
Unknown Object (File)
Thu, Oct 31, 11:43 AM
Unknown Object (File)
Oct 7 2024, 4:42 AM
Unknown Object (File)
Oct 7 2024, 12:25 AM
Unknown Object (File)
Oct 7 2024, 12:25 AM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• abosh
Commits
rCOMMc390b84cba08: [lib] Update `messageStore.messages` with `msgStoreOps` for remaining action…
Summary

These are the last actions in reduceMessageStore that need to be modified so we can remove assertMessageStoreMessagesAreEqual and solely use the "ops approach" to update messageStore.messages in redux.

The two remaining instances of assertMessageStoreMessagesAreEqual are in mergeNewMessages and will be addressed in the next diff.

Depends on D4330

Test Plan

This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 2:24 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 2:24 PM
Harbormaster completed remote builds in B9894: Diff 13686.Jun 22 2022, 2:29 PM
atul requested review of this revision.Jun 22 2022, 2:29 PM
atul edited the summary of this revision. (Show Details)Jun 22 2022, 2:43 PM
atul added a parent revision: D4330: [lib] Update `messageStore.messages` with `msgStoreOps` for `sendText/MultimediaMessage.started` actions.
atul added a child revision: D4332: [lib] Replace `mergedStore.messages` with `processedStore.messages` in `mergeNewMessages`.Jun 22 2022, 2:50 PM
tomek accepted this revision.Jun 23 2022, 3:35 AM
This revision is now accepted and ready to land.Jun 23 2022, 3:35 AM
atul updated this revision to Diff 13746.Jun 23 2022, 7:43 PM

rebase after cherrypicking and before landing

Harbormaster completed remote builds in B9942: Diff 13746.Jun 23 2022, 7:48 PM
Closed by commit rCOMMc390b84cba08: [lib] Update `messageStore.messages` with `msgStoreOps` for remaining action… (authored by atul). · Explain WhyJun 23 2022, 7:59 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc390b84cba08: [lib] Update `messageStore.messages` with `msgStoreOps` for remaining action….

Revision Contents
Changeset List

PathSize
lib/
reducers/
80 lines

Diff 13747

View Options

lib/reducers/message-reducer.js

Loading...