Paths

Table of Contentst

Differential D4332

[lib] Replace `mergedStore.messages` with `processedStore.messages` in `mergeNewMessages`
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 2:50 PM.

Tags

None

Referenced Files

	F3498884: D4332.id13687.diff
	Thu, Dec 19, 9:49 PM

	F3498470: D4332.id13748.diff
	Thu, Dec 19, 9:18 PM

	F3496862: D4332.diff
	Thu, Dec 19, 3:57 PM

	Unknown Object (File)
	Sun, Dec 15, 4:52 PM

	Unknown Object (File)
	Sun, Dec 15, 4:52 PM

	Unknown Object (File)
	Sun, Dec 15, 4:52 PM

	Unknown Object (File)
	Sun, Dec 15, 4:52 PM

	Unknown Object (File)
	Sun, Dec 15, 4:52 PM

Subscribers

Details

Reviewers

• jacek
tomek
• abosh

Commits

rCOMMbd034f550909: [lib] Replace `mergedStore.messages` with `processedStore.messages` in…

Summary

This diff removes the second-to-last usage of assertMessageStoreMessagesAreEqual(...) in message-reducer. The last usage is also in mergeNewMessages, but the logic there is more involved so I'm going to take a second to read through it again and put up a seperate diff.

Depends on D4331

Test Plan

This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 2:50 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 2:50 PM

Harbormaster completed remote builds in B9895: Diff 13687.Jun 22 2022, 2:54 PM

atul requested review of this revision.Jun 22 2022, 2:54 PM

atul added a child revision: D4333: [lib] Remove `assertMessageStoreMessagesAreEqual(...)` from `message-reducer`.Jun 22 2022, 3:02 PM

tomek accepted this revision.Jun 23 2022, 3:42 AM

This revision is now accepted and ready to land.Jun 23 2022, 3:42 AM

• abosh accepted this revision.Jun 23 2022, 7:33 AM

rebase after cherrypicking and before landing

Harbormaster completed remote builds in B9943: Diff 13748.Jun 23 2022, 8:15 PM

Closed by commit rCOMMbd034f550909: [lib] Replace `mergedStore.messages` with `processedStore.messages` in… (authored by atul). · Explain WhyJun 23 2022, 8:22 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbd034f550909: [lib] Replace `mergedStore.messages` with `processedStore.messages` in….

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

15 lines

Diff 13749

lib/reducers/message-reducer.js

Loading...