[nix] Opt-out out of nvm usage with nix
ClosedPublic
Actions

Authored by • jon on Jun 30 2022, 1:24 PM.

Details

Reviewers

ashoat
varun
atul
tomek

Commits

rCOMM616d33c1e0e4: [nix] Opt-out out of nvm usage with nix

Summary

Nix is able to determine the desired version
when entering the development shell.

https://linear.app/comm/issue/ENG-908

Test Plan

nix develop, then do dev workflow in web and keyserver directories

Diff Detail

Repository

rCOMM Comm

Branch

joringer/keyserver-nix-fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jun 30 2022, 1:24 PM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJun 30 2022, 1:24 PM

Harbormaster completed remote builds in B10177: Diff 14048.Jun 30 2022, 1:36 PM

• jon requested review of this revision.Jun 30 2022, 1:36 PM

See comment in ENG-629:

As mentioned above, we need to replace nvm, not just introduce an alternative to it. I would not recommend attempting the replacement until the Node dev environment is actually working, though (I don't think it is – see notes in ENG-628)

I am skeptical that we're ready for this right now. We rely on nvm for a lot. I think it would be better to start by getting the Node dev environment actually working. Then you'll know what you need to test. Once you have the environment working and you've tested all the edge cases, we'll be in a good place to try getting rid of nvm.

This revision now requires changes to proceed.Jun 30 2022, 1:44 PM

I might be overreacting here a little bit... is the environment for developing web / server actually working in Nix? Has any dev on the team tried it yet? Maybe if that's working we can make an argument for this.

And separately, I guess there's not really a downside to pushing this diff? It just seems like the wrong prioritization / ordering of work, but again I might be off-base.

Curious for @varun, @atul, and @palys-swm's perspectives.

Accepting this after seeing a comment in Linear, and thinking about it more. Probably no downside to doing this now

This revision is now accepted and ready to land.Jun 30 2022, 1:53 PM

This should be a no-op to the existing workflow.

I am skeptical that we're ready for this right now. We rely on nvm for a lot. I think it would be better to start by getting the Node dev environment actually working. Then you'll know what you need to test. Once you have the environment working and you've tested all the edge cases, we'll be in a good place to try getting rid of nvm.

I think it would probably be best for me to just pair with someone who is doing node work.

Looks ok to me - if someone uses nix for development, they might be affected, but I don't know if anyone tried that.

Overall, we should avoid breaking the old workflow before the new one is used by most of the team.

Closed by commit rCOMM616d33c1e0e4: [nix] Opt-out out of nvm usage with nix (authored by • jon). · Explain WhyJul 3 2022, 8:36 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM616d33c1e0e4: [nix] Opt-out out of nvm usage with nix.

ashoat mentioned this in D4422: [keyserver] Use `[[ ]]` instead of `[ ]` in `source-nvm.sh`.Jul 3 2022, 11:50 AM