Page MenuHomePhabricator
Differential D4506

[server] Add delay before setuping database and running migrations
ClosedPublic
Actions

Authored by • jacek on Jul 12 2022, 5:26 AM.
Tags
None
Referenced Files
F3396455: D4506.id14458.diff
Sun, Dec 1, 12:27 PM
F3395670: D4506.diff
Sun, Dec 1, 6:51 AM
F3395039: D4506.id14459.diff
Sun, Dec 1, 1:14 AM
Unknown Object (File)
Thu, Nov 28, 10:35 PM
Unknown Object (File)
Sat, Nov 2, 9:50 AM
Unknown Object (File)
Sat, Nov 2, 9:50 AM
Unknown Object (File)
Sat, Nov 2, 9:50 AM
Unknown Object (File)
Sat, Nov 2, 9:50 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM4e21e3d264df: [server] Add delay before setuping database and running migrations
Summary

Linear: https://linear.app/comm/issue/ENG-1350/investigate-why-new-messages-are-not-displayed-when-keyserver
Introduce 5s delay before running database setup script and migrations in dev mode.
This prevents executing migrations and db setup script while project files are compiled after running yarn dev and nodemon restarts a few times.

Test Plan

I dropped database, and run yarn dev with and without fix, confirming that DB setup was fully completed using logs. Also checked threads table in DB to confirm the initial threads are created.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/db-creation-fix
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Jul 12 2022, 5:26 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 12 2022, 5:26 AM
• jacek edited the summary of this revision. (Show Details)Jul 12 2022, 5:27 AM
Harbormaster completed remote builds in B10464: Diff 14409.Jul 12 2022, 5:38 AM
• jacek requested review of this revision.Jul 12 2022, 5:38 AM
ashoat accepted this revision.Jul 12 2022, 12:08 PM
ashoat added inline comments.
keyserver/src/database/migrations.js
15

This variable declaration should be grouped with the try-catch that sets it below

This revision is now accepted and ready to land.Jul 12 2022, 12:08 PM
• jacek added a child revision: D4514: [server] Use single connection with DB for migrations.Jul 13 2022, 8:08 AM
• jacek added inline comments.Jul 13 2022, 8:13 AM
keyserver/src/database/migrations.js
15

I think it can't be inside try-catch, because it's used in line 30 - out of the block. Or do you mean just moving it to line 19?

ashoat added inline comments.Jul 13 2022, 8:34 AM
keyserver/src/database/migrations.js
15

Yes that's what I mean

• jacek updated this revision to Diff 14458.Jul 14 2022, 4:03 AM

move dbVersion closer to where it's used

Harbormaster completed remote builds in B10510: Diff 14458.Jul 14 2022, 4:15 AM
Closed by commit rCOMM4e21e3d264df: [server] Add delay before setuping database and running migrations (authored by • jacek). · Explain WhyJul 14 2022, 4:16 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM4e21e3d264df: [server] Add delay before setuping database and running migrations.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
6 lines

Diff 14409

View Options

keyserver/src/database/migrations.js

Loading...