Page MenuHomePhabricator

[Chore] Ignore cmake build directories
ClosedPublic

Authored by jon on Jul 8 2022, 9:55 PM.
Tags
None
Referenced Files
F3386441: D4487.id14372.diff
Fri, Nov 29, 4:46 AM
F3386424: D4487.id14532.diff
Fri, Nov 29, 4:38 AM
Unknown Object (File)
Sat, Nov 16, 9:05 AM
Unknown Object (File)
Thu, Nov 14, 10:11 PM
Unknown Object (File)
Sun, Nov 10, 12:13 AM
Unknown Object (File)
Fri, Nov 8, 2:41 AM
Unknown Object (File)
Tue, Nov 5, 8:32 AM
Unknown Object (File)
Oct 27 2024, 4:32 AM

Details

Summary

Prevent build directories from
accidently being added

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested changes to this revision.Jul 9 2022, 10:47 AM

This is super general... can you share a list of the directories where this will come up? Wondering if we can prepend something in front of **/build maybe to at least limit this to the two or three subdirectories where we expect CMake builds to occur.

This revision now requires changes to proceed.Jul 9 2022, 10:47 AM

Limit directory traversal to CMake directories

I scoped the directories to be much smaller

This revision is now accepted and ready to land.Jul 17 2022, 7:30 AM
This revision was automatically updated to reflect the committed changes.