Page MenuHomePhabricator
Differential D4537

[services] Tunnelbroker - Add Cargo manifest, headers and Rust linking to the CMakeLists
ClosedPublic
Actions

Authored by • max on Jul 14 2022, 8:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 6:20 PM
Unknown Object (File)
Sun, Oct 20, 5:08 PM
Unknown Object (File)
Oct 10 2024, 11:36 PM
Unknown Object (File)
Oct 10 2024, 11:12 PM
Unknown Object (File)
Oct 7 2024, 11:04 AM
Unknown Object (File)
Oct 7 2024, 11:04 AM
Unknown Object (File)
Oct 7 2024, 11:04 AM
Unknown Object (File)
Oct 7 2024, 11:04 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jon
• karol
tomek

Details

Reviewers
varun
tomek
• karol
• jon
Commits
rCOMM682b9d38046b: [services] Tunnelbroker - Add Cargo manifest, headers and Rust linking to the…
Summary

Add Cargo manifest, headers, and Rust linkings to the CMakeLists file to build the Rust library.

Linear task: ENG-1330

Test Plan

Running build using the standard command yarn run-tunnelbroker-service successfully built an empty rust library and link it to the CMake project.

Diff Detail

Repository
rCOMM Comm
Branch
update-cmakelists-with-cargo
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Jul 14 2022, 8:00 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 14 2022, 8:00 AM
• max edited the summary of this revision. (Show Details)Jul 14 2022, 8:02 AM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: varun, tomek, • karol.
• max added parent revisions: D4534: [services] Tunnelbroker - Add Cargo manifest file, D4535: [services] Tunnelbroker - Add dependencies to Cargo.toml manifest and Cargo.lock files, D4533: [services] Tunnelbroker - Append Rust build output folder to our global `.gitignore`.
Harbormaster completed remote builds in B10532: Diff 14496.Jul 14 2022, 8:13 AM
• max added a child revision: D4540: [services] Tunnelbroker - Rust APNS push notifications A2 library wrapper.Jul 14 2022, 8:19 AM
• max published this revision for review.Jul 14 2022, 8:26 AM
ashoat added a reviewer: • jon. ashoat removed 1 blocking reviewer(s): tomek.Jul 14 2022, 12:53 PM
ashoat added a subscriber: • jon.

Let's make sure we include @jonringer-comm on all CMake-related diffs going forward! Also removing @palys-swm from blocking since he is sick right now and has a huge backlog of reviews

• jon accepted this revision.Jul 14 2022, 3:23 PM
varun accepted this revision.Jul 15 2022, 8:28 AM
This revision is now accepted and ready to land.Jul 15 2022, 8:28 AM
• max updated this revision to Diff 14530.Jul 15 2022, 10:45 AM

Rebase on the stack changes.

• max edited the summary of this revision. (Show Details)Jul 15 2022, 10:46 AM
Harbormaster completed remote builds in B10557: Diff 14530.Jul 15 2022, 10:56 AM
• max updated this revision to Diff 14672.Jul 20 2022, 3:05 AM

Rebased on master.

Harbormaster completed remote builds in B10658: Diff 14672.Jul 20 2022, 3:18 AM
Closed by commit rCOMM682b9d38046b: [services] Tunnelbroker - Add Cargo manifest, headers and Rust linking to the… (authored by • max). · Explain WhyJul 20 2022, 3:28 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM682b9d38046b: [services] Tunnelbroker - Add Cargo manifest, headers and Rust linking to the….
• max removed a child revision: D4540: [services] Tunnelbroker - Rust APNS push notifications A2 library wrapper.Jul 20 2022, 3:31 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
11 lines

Diff 14672

View Options

services/tunnelbroker/CMakeLists.txt

Loading...