[web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode
ClosedPublic
Actions

Authored by • jacek on Jul 7 2022, 6:39 AM.

Details

Reviewers

tomek
atul
• abosh

Commits

rCOMMf99f20f2579e: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in…

Summary

The diff introduces updating activeChatThreadID and pendingThread in navInfo in thread creation mode.
These values from navInfo are not used by chat-message-list-container when creating thread, but can be read from different places of the app - e.g. by ThreadListProvider.
After the change, thread currently being created (or selected from existing by matching users) is correctly displayed in the thread list on the left, and after clicking on the thread on list, the creation mode is closed and pending thread is correctly being displayed.

Test Plan

Selecting some new set of users in thread creation mode to display pending thread. It should be correclty displayed on the top of the thread list.
After clicking on the thread, creation mode should be closed and pending thread should remain open (even after page refresh)

Diff Detail

Repository

rCOMM Comm

Branch

jacek/thread-creation-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Jul 7 2022, 6:39 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 7 2022, 6:39 AM

• jacek added parent revisions: D4465: [web] Support chat creation in `ChatMessageListContainer`, D4456: [web] Include current pending thread in thread list.Jul 7 2022, 6:41 AM

• jacek added a child revision: D4469: [web] Introduce "Create new chat" button.

Harbormaster completed remote builds in B10357: Diff 14265.Jul 7 2022, 6:57 AM

• jacek requested review of this revision.Jul 7 2022, 6:57 AM

• jacek added a reviewer: • abosh.Jul 7 2022, 7:22 AM

tomek accepted this revision.Jul 20 2022, 5:07 AM

tomek added inline comments.

web/chat/chat-message-list-container.react.js
114 ↗	(On Diff #14265)	Is it possible to avoid having an effect and Set correct nav info when navigating or Determine `pendingThread` in a reducer?
134–135 ↗	(On Diff #14265)	We can merge these

This revision is now accepted and ready to land.Jul 20 2022, 5:07 AM

~~changed the types to () => mixed & wrap using useCallback~~
Accidentally added description from different diff

• jacek planned changes to this revision.Jul 21 2022, 5:51 AM

Harbormaster completed remote builds in B10729: Diff 14768.Jul 21 2022, 6:01 AM

• jacek added inline comments.Jul 21 2022, 6:29 AM

web/chat/chat-message-list-container.react.js
114 ↗	(On Diff #14265)	We update `navInfo` hare with data calculated by `existingThreadInfoFinder`, so to handle navigation update in reducer we'd need to move all the logic responsible for finding thread to reducer. Atul suggested in D4455 that we should keep nav-reducer possibly clean and clear, and moving the thread selection logic there would definitely make reducer really complex. Determining pending thread in reducer basing on `activeChatThreadID` is possible, and was introduced in the first iteration of D4455, but we decided to move it out of reducer, to keep reducer clear. However, finding proper `activeChatThreadID`there is quite complex (using `existingThreadInfoFinder`).