Page MenuHomePhabricator
Differential D4560

[lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action
ClosedPublic
Actions

Authored by atul on Jul 18 2022, 1:44 PM.
Tags
None
Referenced Files
F3353718: D4560.diff
Sat, Nov 23, 11:02 AM
Unknown Object (File)
Sat, Nov 2, 10:33 AM
Unknown Object (File)
Oct 22 2024, 3:45 PM
Unknown Object (File)
Oct 7 2024, 2:15 PM
Unknown Object (File)
Oct 7 2024, 2:15 PM
Unknown Object (File)
Oct 7 2024, 2:15 PM
Unknown Object (File)
Oct 7 2024, 2:15 PM
Unknown Object (File)
Oct 7 2024, 2:14 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
marcin
tomek
Commits
rCOMMa7ccdefd49ef: [lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action
Summary

Had trouble debugging D4508 because I couldn't "attach" debugger to hermes in time for message-reducer.js:SET_MESSAGE_STORE_MESSAGES to hit.

Ended up testing via console.log(...) and pasting values into a text file to ensure that things were as expected. The stuff I jotted down lent itself well to writing basic unit tests so figured I might as well put it up.

Depends on D4508

Test Plan

Ran tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jul 18 2022, 1:44 PM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 18 2022, 1:44 PM
Harbormaster completed remote builds in B10592: Diff 14584.Jul 18 2022, 1:56 PM
atul requested review of this revision.Jul 18 2022, 1:56 PM
tomek accepted this revision.Jul 19 2022, 2:44 AM
This revision is now accepted and ready to land.Jul 19 2022, 2:44 AM
atul edited the summary of this revision. (Show Details)Jul 20 2022, 7:26 AM
atul added a parent revision: D4508: Filter local multimedia messages.
atul updated this revision to Diff 14782.Jul 21 2022, 12:13 PM

rebase before landign

atul updated this revision to Diff 14783.Jul 21 2022, 12:15 PM

rebase before landing

Harbormaster completed remote builds in B10742: Diff 14782.Jul 21 2022, 12:25 PM
Harbormaster completed remote builds in B10743: Diff 14783.
Closed by commit rCOMMa7ccdefd49ef: [lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action (authored by atul). · Explain WhyJul 21 2022, 2:15 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMa7ccdefd49ef: [lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action.

Revision Contents
Changeset List

PathSize
lib/
reducers/
107 lines

Diff 14796

View Options

lib/reducers/message-reducer.test.js

Loading...