Differential D4615

[web] Move selected chat to the top of the list in creation mode
ClosedPublic
Actions

Authored by • jacek on Jul 25 2022, 3:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 21, 7:39 AM

	Unknown Object (File)
	Wed, Mar 19, 6:46 PM

	Unknown Object (File)
	Sat, Mar 15, 7:08 PM

	Unknown Object (File)
	Fri, Mar 14, 1:15 PM

	Unknown Object (File)
	Fri, Mar 14, 5:07 AM

	Unknown Object (File)
	Thu, Mar 13, 9:03 AM

	Unknown Object (File)
	Tue, Mar 11, 8:09 PM

	Unknown Object (File)
	Wed, Mar 5, 10:56 AM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM1d3670bbd248: [web] Move selected chat to the top of the list in creation mode

Summary

When selecting user for new chat, an existing chat can be matched and selected. However it is often not visible in chat list because in's not near the top.
The diff fixes this by moving active thread in chat creation to the top of the chat list
This is the follow-up diff after: https://phab.comm.dev/D4461#131918

Test Plan

Start chat creation, select set of users matching existing chat, that is not near the top of the list. It should be at the top after this diff.

Diff Detail

Repository

Branch

jacek/thread-creation-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Jul 25 2022, 3:05 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 25 2022, 3:05 AM

• jacek mentioned this in D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.Jul 25 2022, 3:08 AM

• jacek added a parent revision: D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.Jul 25 2022, 3:11 AM

Harbormaster completed remote builds in B10785: Diff 14826.Jul 25 2022, 3:17 AM

• jacek requested review of this revision.Jul 25 2022, 3:17 AM

• jacek added a child revision: D4469: [web] Introduce "Create new chat" button.Jul 25 2022, 7:15 AM

tomek accepted this revision.Jul 25 2022, 8:50 AM

This revision is now accepted and ready to land.Jul 25 2022, 8:50 AM

Closed by commit rCOMM1d3670bbd248: [web] Move selected chat to the top of the list in creation mode (authored by • jacek). · Explain WhyJul 26 2022, 3:06 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM1d3670bbd248: [web] Move selected chat to the top of the list in creation mode.

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-list-provider.js

19 lines

Diff 14826

web/chat/thread-list-provider.js

This file was moved to native/cpp/third-party/sqlite_orm/LICENSE.