[server] Support pending threads when calculating `finalNavInfo`
ClosedPublic
Actions

Authored by • jacek on Jul 4 2022, 8:37 AM.

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM00d18fc18e7b: [server] Support pending threads when calculating `finalNavInfo`

Summary

Currently, on server side, when calculating initial navInfo, there is a check that redirects user to latest thread, if the user has no permission to read the thread.
However, there is no check if thread with ID calculated from URL even exist in store. As we want to support navigation with pending threads, the non-existing thread IDs should not be removed on server side.

Test Plan

The app behavior remains unchanged, if non-existing ID is entered, the user is still redirected correctly. Support for pending threads on React side will be introduced in following diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 4 2022, 8:37 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 4 2022, 8:37 AM

Harbormaster completed remote builds in B10242: Diff 14134.Jul 4 2022, 8:50 AM

• jacek requested review of this revision.Jul 4 2022, 8:50 AM

Do you think we can check threadIsPending instead? I think it's probably good that we unset the activeChatThreadID if it is non-pending but does not exist in threadInfos.

This revision now requires changes to proceed.Jul 4 2022, 1:10 PM

In D4435#125813, @ashoat wrote:

Do you think we can check threadIsPending instead? I think it's probably good that we unset the activeChatThreadID if it is non-pending but does not exist in threadInfos.

Agree - the isPending check is even more precise condition here. Although, there is no much difference in both cases - when checking threadInfos[requestedActiveChatThreadID] the ID for non-existing non-pending thread was unset in frontend side. But it's probably better to handle this case here in responder.