Page MenuHomePhabricator
Differential D4600

Introduce iOS and Android notification max size thresholds as constants
ClosedPublic
Actions

Authored by marcin on Jul 21 2022, 7:57 AM.
Tags
None
Referenced Files
F3376343: D4600.diff
Tue, Nov 26, 11:29 PM
Unknown Object (File)
Sat, Nov 9, 11:38 AM
Unknown Object (File)
Sat, Nov 9, 6:29 AM
Unknown Object (File)
Fri, Nov 8, 9:04 PM
Unknown Object (File)
Fri, Nov 8, 8:37 PM
Unknown Object (File)
Fri, Nov 8, 8:37 PM
Unknown Object (File)
Fri, Nov 8, 8:37 PM
Unknown Object (File)
Fri, Nov 8, 8:37 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
Commits
rCOMM9b7fde3b227d: Introduce iOS and Android notification max size thresholds as constants
Summary

According to documentations, iOS max notification size is 4096 bytes, while for Android (FCM) it is 4000 bytes. Including this constants in 'utils' since there are some other constants related to notifications.

Test Plan

There is no test plan for this issue. Links to documentation that support values are in the Linear

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jul 21 2022, 7:57 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 21 2022, 7:57 AM
Harbormaster completed remote builds in B10738: Diff 14777.Jul 21 2022, 8:10 AM
marcin requested review of this revision.Jul 21 2022, 8:10 AM
• jacek mentioned this in D4601: Remove messageInfos fileds from iOS notification if its size exceeds defined limit.Jul 22 2022, 1:21 AM
marcin updated this revision to Diff 14803.Jul 22 2022, 2:58 AM

Remove redundant function definition

Harbormaster completed remote builds in B10762: Diff 14803.Jul 22 2022, 3:11 AM
tomek accepted this revision.Jul 22 2022, 6:39 AM
tomek added inline comments.
keyserver/src/push/utils.js
23 ↗(On Diff #14803)

Maybe notification to avoid confusion?

This revision is now accepted and ready to land.Jul 22 2022, 6:39 AM
marcin added a child revision: D4601: Remove messageInfos fileds from iOS notification if its size exceeds defined limit.Jul 25 2022, 1:44 AM
marcin updated this revision to Diff 14834.Jul 25 2022, 6:18 AM

Rename message to notification in constants

marcin edited child revisions, added: D4617: Introduce length() method in apn.Notification flow-typed; removed: D4601: Remove messageInfos fileds from iOS notification if its size exceeds defined limit.Jul 25 2022, 6:23 AM
Harbormaster completed remote builds in B10790: Diff 14834.Jul 25 2022, 6:30 AM
marcin added a child revision: D4643: Remove messageInfos from Android notification if its size exceeds fcm limits.Jul 27 2022, 5:08 AM
marcin added a child revision: D4732: Increase min code version so that we can safely ignore unconvenient android notification structure edge case.Aug 3 2022, 7:39 AM
marcin removed a child revision: D4643: Remove messageInfos from Android notification if its size exceeds fcm limits.
marcin updated this revision to Diff 15268.Aug 3 2022, 7:59 AM

Rebase master before landing

Harbormaster completed remote builds in B11089: Diff 15268.Aug 3 2022, 8:12 AM
Closed by commit rCOMM9b7fde3b227d: Introduce iOS and Android notification max size thresholds as constants (authored by marcin). · Explain WhyAug 3 2022, 8:15 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM9b7fde3b227d: Introduce iOS and Android notification max size thresholds as constants.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
10 lines

Diff 14834

View Options

keyserver/src/push/utils.js

Loading...