Page MenuHomePhabricator
Differential D4456

[web] Include current pending thread in thread list
ClosedPublic
Actions

Authored by • jacek on Jul 6 2022, 4:53 AM.
Tags
None
Referenced Files
F3385876: D4456.diff
Fri, Nov 29, 2:50 AM
Unknown Object (File)
Tue, Nov 12, 1:09 AM
Unknown Object (File)
Tue, Nov 12, 1:09 AM
Unknown Object (File)
Tue, Nov 12, 1:09 AM
Unknown Object (File)
Tue, Nov 12, 1:09 AM
Unknown Object (File)
Fri, Nov 8, 3:24 PM
Unknown Object (File)
Fri, Nov 8, 3:23 PM
Unknown Object (File)
Fri, Nov 8, 3:22 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
• abosh
Commits
rCOMM4aaa1bb72682: [web] Include current pending thread in thread list
Summary

Currently opened pending thread hasn't been displayed in thread list (only pending sidebar was included). This change includes it in the list (similar to pending sidebar).

Test Plan

Create new pending thread (e.g. by opening empty thread with non-friend). It should be displayed on the top of the thread list.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 6 2022, 4:53 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 6 2022, 4:53 AM
Harbormaster completed remote builds in B10321: Diff 14227.Jul 6 2022, 5:11 AM
• jacek requested review of this revision.Jul 6 2022, 5:11 AM
• jacek added a child revision: D4465: [web] Support chat creation in `ChatMessageListContainer`.Jul 7 2022, 6:07 AM
• jacek added a child revision: D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.Jul 7 2022, 6:41 AM
• jacek added a reviewer: • abosh.Jul 7 2022, 7:20 AM
• abosh added inline comments.Jul 7 2022, 7:49 AM
web/chat/thread-list-provider.js
85–88 ↗(On Diff #14227)

Although you did not make this change, this can be made cleaner with a ternary.

tomek accepted this revision.Jul 11 2022, 7:12 AM
This revision is now accepted and ready to land.Jul 11 2022, 7:12 AM
Closed by commit rCOMM4aaa1bb72682: [web] Include current pending thread in thread list (authored by • jacek). · Explain WhyJul 25 2022, 6:56 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM4aaa1bb72682: [web] Include current pending thread in thread list.

Revision Contents
Changeset List

PathSize
web/
chat/
26 lines

Diff 14849

View Options

web/chat/thread-list-provider.js

Loading...