Page MenuHomePhabricator
Differential D4464

[web] Close thread composer after sending a message
ClosedPublic
Actions

Authored by • jacek on Jul 7 2022, 3:28 AM.
Tags
None
Referenced Files
F3668196: D4464.id14244.diff
Sun, Jan 5, 11:07 PM
F3663739: D4464.diff
Sun, Jan 5, 5:29 PM
F3651998: D4464.id14937.diff
Sun, Jan 5, 7:06 AM
F3651997: D4464.id14922.diff
Sun, Jan 5, 7:06 AM
F3651996: D4464.id14244.diff
Sun, Jan 5, 7:06 AM
F3651957: D4464.id.diff
Sun, Jan 5, 7:05 AM
F3651902: D4464.diff
Sun, Jan 5, 7:00 AM
Unknown Object (File)
Fri, Dec 27, 4:29 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
• abosh
Commits
rCOMM8812e9359992: [web] Close thread composer after sending a message
Summary

Register hideSearch callback to be executed after sending a message, so the chat creation view disappear when sending to the message.

Test Plan

After introducing chat creation view, sending any message into existing or pending thread in thread creation mode should close the thread composer panel.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Jul 7 2022, 3:28 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 7 2022, 3:28 AM
Harbormaster completed remote builds in B10336: Diff 14244.Jul 7 2022, 3:40 AM
• jacek requested review of this revision.Jul 7 2022, 3:40 AM
• jacek added a child revision: D4465: [web] Support chat creation in `ChatMessageListContainer`.Jul 7 2022, 4:02 AM
• jacek added a parent revision: D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`.Jul 7 2022, 5:58 AM
• jacek added a reviewer: • abosh.Jul 7 2022, 7:21 AM
atul accepted this revision.Jul 19 2022, 1:29 PM

Nice!

This revision is now accepted and ready to land.Jul 19 2022, 1:29 PM
tomek accepted this revision.Jul 20 2022, 3:33 AM
• jacek updated this revision to Diff 14922.Jul 26 2022, 2:33 AM

rebase

Harbormaster completed remote builds in B10859: Diff 14922.Jul 26 2022, 2:46 AM
Closed by commit rCOMM8812e9359992: [web] Close thread composer after sending a message (authored by • jacek). · Explain WhyJul 26 2022, 3:06 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM8812e9359992: [web] Close thread composer after sending a message.

Revision Contents
Changeset List

PathSize
web/
chat/
10 lines

Diff 14922

View Options

web/chat/chat-thread-composer.react.js

Loading...