Paths

Table of Contentst

[services] Blob - Get Reactor - Fix initialize logic
ClosedPublic
Actions

Authored by • karol on Jul 27 2022, 2:46 AM.

Details

Reviewers

tomek
• max

Commits

rCOMM855ee8f2d104: [services] Blob - Get Reactor - Fix initialize logic

Summary

I spotted that the logic in GetReactor::initialize is a bit odd and contains duplicated logic. I think it can be simplified as it is done in this diff.

Test Plan

terminal 1

cd services
yarn run-blob-service-in-sandbox

terminal 2

cd services
yarn run-integration-tests blob

Diff Detail

Repository

rCOMM Comm

Branch

fix-logic-get-reactor

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 27 2022, 2:46 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 27 2022, 2:46 AM

• karol edited the summary of this revision. (Show Details)Jul 27 2022, 2:48 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

Harbormaster completed remote builds in B10903: Diff 15002.Jul 27 2022, 2:59 AM

• karol requested review of this revision.Jul 27 2022, 2:59 AM

tomek accepted this revision.Jul 27 2022, 4:44 AM

This revision is now accepted and ready to land.Jul 27 2022, 4:44 AM

• karol added a child revision: D4651: [services] Blob - PullBackupReactor - Simplify write response logic.Jul 27 2022, 6:14 AM

Closed by commit rCOMM855ee8f2d104: [services] Blob - Get Reactor - Fix initialize logic (authored by • karol). · Explain WhyAug 2 2022, 3:05 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM855ee8f2d104: [services] Blob - Get Reactor - Fix initialize logic.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

Reactors/

server/

GetReactor.h

11 lines

Diff 15002

View Options

services/blob/src/Reactors/server/GetReactor.h

[services] Blob - Get Reactor - Fix initialize logicClosedPublicActions