Page MenuHomePhabricator
Differential D4658

[services] implement getUserID rpc
ClosedPublic
Actions

Authored by varun on Jul 27 2022, 2:52 PM.
Tags
None
Referenced Files
F3351969: D4658.diff
Sat, Nov 23, 4:15 AM
Unknown Object (File)
Sat, Nov 16, 12:11 PM
Unknown Object (File)
Sat, Nov 16, 10:11 AM
Unknown Object (File)
Sun, Nov 10, 12:40 AM
Unknown Object (File)
Tue, Nov 5, 9:56 PM
Unknown Object (File)
Tue, Nov 5, 9:39 PM
Unknown Object (File)
Sun, Oct 27, 6:19 PM
Unknown Object (File)
Sun, Oct 27, 6:19 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• karol
Commits
rCOMMb097b3dcdd6d: [services] implement getUserID rpc
Summary

This RPC lets a client get a user ID corresponding to a given wallet address or username.

Depends on D4657

Test Plan

Ran the service and called the RPC, retrieved the correct user ID from DynamoDB with a wallet address and a username

Diff Detail

Repository
rCOMM Comm
Branch
identity (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jul 27 2022, 2:52 PM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 27 2022, 2:52 PM
varun edited the test plan for this revision. (Show Details)Jul 27 2022, 2:53 PM
Harbormaster completed remote builds in B10922: Diff 15028.Jul 27 2022, 3:05 PM
varun requested review of this revision.Jul 27 2022, 3:05 PM
tomek accepted this revision.Jul 28 2022, 3:00 AM
tomek added inline comments.
services/identity/src/service.rs
360

Wondering if we should log this request. Can it contain sensitive data?

380–391

This code is duplicated. Is there a way to extract common logic from it?

This revision is now accepted and ready to land.Jul 28 2022, 3:00 AM
ashoat added inline comments.Jul 28 2022, 6:38 AM
services/identity/src/service.rs
360

We should avoid logging things like user IDs

360

More context: https://phab.comm.dev/D4652#133661

varun added inline comments.Jul 28 2022, 11:40 AM
services/identity/src/service.rs
360

ok, will remove this and similar logs

380–391

yeah we can have a function that handles matching errors, i'll try to implement that

varun updated this revision to Diff 15068.Jul 28 2022, 12:46 PM

avoid duplicating DBError arms in match statements

This revision was landed with ongoing or failed builds.Jul 28 2022, 12:49 PM
Closed by commit rCOMMb097b3dcdd6d: [services] implement getUserID rpc (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMb097b3dcdd6d: [services] implement getUserID rpc.
Harbormaster completed remote builds in B10953: Diff 15068.Jul 28 2022, 12:58 PM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
36 lines

Diff 15028

View Options

services/identity/src/service.rs

Loading...